[Subscription Billing]Calculating initial dates correctly #6352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request primarily simplifies and clarifies the handling of subscription line term calculations and improves the consistency of tooltips across multiple pages. The most significant change is a refactor of the logic for calculating the "Term Until" and "Cancellation Possible Until" dates, removing redundant methods and ensuring that the calculations align more closely with business rules. Additionally, the tooltips for the "Extension Term" field have been standardized across various pages for clarity.
Key changes include:
Subscription line calculation logic refactor
CalculateInitialCancellationPossibleUntilDatemethod fromSubscriptionLineand updated the logic inCalculateInitialTermUntilDateto handle both "Term Until" and "Cancellation Possible Until" calculations, streamlining the process and reducing redundancy.Sales Documents,Create Subscription Line,Post Sub. Contract Renewal) and theSubscription Headertable to remove calls to the now-deletedCalculateInitialCancellationPossibleUntilDateand ensure correct sequencing of term calculations.UI/UX and documentation consistency
Data consistency improvements
Renewal Termfield is now copied fromServiceCommitmenttoSub. Contr. Analysis Entryfor improved data consistency in contract analysis.Technical code review from @samra-singhammer or @sit-zm required prior to approval by Microsoft.
Work Item(s)
Fixes #6132