Issue 6272,manually changing the source table or intent does not chan… #6327
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge default triggers
github-actions
bot
added
AL: Apps (W1)
JakovljevicDusan
approved these changes
Jan 27, 2026
| SetDefaultTriggerValuesToNoTrigger(); | ||
| if Rec."Activation Trigger" in [Rec."Activation Trigger"::"Manual or Automatic", Rec."Activation Trigger"::"Automatic only"] then | ||
| if Rec."Activation Trigger" in [Rec."Activation Trigger"::"Manual or Automatic", Rec."Activation Trigger"::"Automatic only"] then begin | ||
| Rec."Assembly Trigger" := Rec."Assembly Trigger"::NoTrigger; |
Contributor
There was a problem hiding this comment.
Just to check whether it would be better to move this cleanup code outside the conditional logic, to ensure it always executes.
Contributor
Author
There was a problem hiding this comment.
We don't want this reset to always execute, we really just want it to execute in this circumstance.
This particular code change is to improve usability for an edge case on what is an atypical flow in practice (at least based on current installs).
AndreiPanko
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge default triggers
Summary
Request to change the behavior to resets the default action each time the intent changes on a generation rule record.
Work Item(s)
Fixes #6272