Fix CS1998 async warning in PromptForMessagingEndpointAsync#443
Merged
Conversation
PromptForMessagingEndpointAsync was declared async but contains no await operators (it only performs synchronous console I/O), producing CS1998 introduced by PR 440. Remove the async modifier and return values via Task.FromResult, preserving the Task<string?> signature so the caller's await is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
sellakumaran
approved these changes
Jun 4, 2026
abbinayaa
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #440 introduced
PromptForMessagingEndpointAsync, which was declaredasyncbut contains noawaitoperators (it only performs synchronous console I/O). With warnings treated as errors, this produced a build break:What
Removed the
asyncmodifier fromPromptForMessagingEndpointAsyncand returned its values viaTask.FromResult. TheTask<string?>return type is preserved, so the caller'sawaitat the call site is unchanged and the original prompt/validation behavior is fully intact.Verification
dotnet build -c Releaseon the CLI project now succeeds with 0 errors.