Removing package, approve and block develop-mcp commands#439
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Removes the develop-mcp approve, develop-mcp block, and develop-mcp package-mcp-server subcommands from the CLI, along with their supporting service methods, helper class, constants, and tests. These functions are now handled via the Microsoft Admin Center.
Changes:
- Drop
approve,block, andpackage-mcp-serversubcommands and their handlers fromDevelopMcpCommand. - Remove
ApproveServerAsync,BlockServerAsync,GetServerInfoAsyncfromIAgent365ToolingService/Agent365ToolingService, plus URL builder helpers; deletePackageMCPServerHelperand itsMcpConstants.PackageMCPServertemplate. - Update tests (
DevelopMcpCommandTests,DevelopMcpCommandRegressionTests),Helpers/README.md,docs/commands/README.md, and add aCHANGELOG.mdentry under[Unreleased] > Removed.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopMcpCommand.cs | Removes registration and definitions of the three subcommands. |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/IAgent365ToolingService.cs | Removes Approve/Block/GetServerInfo method declarations. |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/Agent365ToolingService.cs | Removes corresponding implementations and URL builders. |
| src/Microsoft.Agents.A365.DevTools.Cli/Helpers/PackageMCPServerHelper.cs | Deletes the packaging helper. |
| src/Microsoft.Agents.A365.DevTools.Cli/Constants/McpConstants.cs | Removes PackageMCPServer constants/template. |
| src/Microsoft.Agents.A365.DevTools.Cli/Helpers/README.md | Drops the helper from the docs table. |
| docs/commands/README.md | Removes the three command links. |
| src/Tests/.../DevelopMcpCommandTests.cs | Adjusts subcommand count/list and removes per-subcommand tests. |
| src/Tests/.../DevelopMcpCommandRegressionTests.cs | Removes approve/block dry-run and integration tests. |
| CHANGELOG.md | Adds Removed entries documenting the deprecations. |
|
PR description is empty. No test plan, no rationale for users of the removed commands, no link to the Admin Center workflow that replaces them. Fill in:
|
|
PR title: "Deprecating package, approve and block mcp commands". The diff deletes handlers, service methods, helper, constants, and tests — that's a removal, not a deprecation (which would keep the commands working and emit a warning). Pick one:
|
|
DO NOT MERGE until #400 is merged |
fa61832 to
1ad4897
Compare
Removes three a365 develop-mcp subcommands whose responsibilities have moved out of the developer CLI and into the Microsoft Admin Center:
a365 develop-mcp approve
a365 develop-mcp block
a365 develop-mcp package-mcp-server
Server approval/blocking and package submission are administrative, tenant-governed operations — they belong with tenant admins in the Admin Center, not in a developer-facing CLI. This PR deletes the commands plus their now-dead supporting code:
Commands/DevelopMcpCommand.cs — the three subcommands (~228 lines)
Helpers/PackageMCPServerHelper.cs — package generation helper
Services/Agent365ToolingService.cs / IAgent365ToolingService.cs — GetServerInfoAsync, ApproveServerAsync, BlockServerAsync
Constants/McpConstants.cs — constants used only by the removed paths
Docs: docs/commands/README.md, Helpers/README.md, CHANGELOG.md
Why now
The approval, blocking, and Admin-Center-submission workflows are now performed directly in the Microsoft Admin Center(https://admin.microsoft.com/#/homepage), making the CLI equivalents redundant and a source of drift (two code paths for the same governance action).Anyone currently scripting these commands should move to the Admin Center:
Removed command Replacement
a365 develop-mcp approve Approve in Microsoft admin center → Requested Agents
a365 develop-mcp block Manage/block in Microsoft admin center → Agents
a365 develop-mcp package-mcp-server No CLI equivalent — admins onboard and manage servers directly in the Microsoft Admin Center; no local package artifact is produced
These are admin operations, so there is intentionally no CLI replacement — the actions require a tenant admin in the Admin Center.
Test Plan