Skip to content

GP - Post migration validation feature #29395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaymckinney-enavate wants to merge 18 commits into
base: main
Choose a base branch
from
Open

GP - Post migration validation feature #29395

jaymckinney-enavate wants to merge 18 commits into from
+3,955 −189

Conversation

@jaymckinney-enavate
Copy link
Contributor

@jaymckinney-enavate jaymckinney-enavate commented Nov 10, 2025

Fixes #579005

@jaymckinney-enavate jaymckinney-enavate requested a review from a team as a code owner November 10, 2025 18:54
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Issue #579005 is not valid. Please make sure you link an issue that exists, is open and is approved.

nikolakukrika
nikolakukrika reviewed Nov 13, 2025
View reviewed changes
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Nov 14, 2025
nikolakukrika
nikolakukrika reviewed Jan 10, 2026
View reviewed changes
nikolakukrika
nikolakukrika reviewed Jan 27, 2026
View reviewed changes
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidation.Codeunit.al Outdated
Clear(CloudMigrationWarning);
CloudMigrationWarning."Entry No." := 0;
CloudMigrationWarning."Warning Type" := CloudMigrationWarning."Warning Type"::"Migration Validator";
CloudMigrationWarning.Message := CopyStr(StrSubstNo(CloudMigrationWarningErr, MigrationValidatorRegistry."Validator Code", GetLastErrorText()), 1, MaxStrLen(CloudMigrationWarning.Message));
Copy link
Contributor

@nikolakukrika nikolakukrika Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list these as errors if the codeunit has failed running?
We may need a callstack too.

Copy link
Contributor Author

@jaymckinney-enavate jaymckinney-enavate Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I just wanted to reuse the existing Cloud Migration Warning functionality to show a failed validator at least somewhere.

nikolakukrika
nikolakukrika reviewed Jan 27, 2026
View reviewed changes
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidatorWarning.Codeunit.al
// The issue should be reported.
end;

procedure ShowWarning(var CloudMigrationWarning: Record "Cloud Migration Warning"): Text
Copy link
Contributor

@nikolakukrika nikolakukrika Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - The method is not showing the warning it is returning text, the name should be udpated

Copy link
Contributor Author

@jaymckinney-enavate jaymckinney-enavate Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is part of the interface, I'm conforming to it. Is there a better way to implement it?

nikolakukrika
nikolakukrika requested changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@nikolakukrika nikolakukrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left feedback

nikolakukrika
nikolakukrika reviewed Jan 28, 2026
View reviewed changes
Apps/W1/HybridBaseDeployment/test/src/MockMigrationValidator.Codeunit.al
end;

// Normally initialized by this event, but called directly for testing.
//[EventSubscriber(ObjectType::Codeunit, Codeunit::"Hybrid Cloud Management", OnPrepareMigrationValidation, '', false, false)]
Copy link
Contributor

@nikolakukrika nikolakukrika Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikolakukrika nikolakukrika nikolakukrika requested changes

@pborring pborring Awaiting requested review from pborring pborring is a code owner automatically assigned from microsoft/dynamics-365-business-central

Requested changes must be addressed to merge this pull request.

Assignees

@nikolakukrika nikolakukrika

Labels

Integration GitHub request for Integration area

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaymckinney-enavate @nikolakukrika @JesperSchulz @jaymckinney