-
Notifications
You must be signed in to change notification settings - Fork 687
Add Analytics demo data module #28860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Analytics demo data module #28860
Conversation
  Test container: http://bcdev2.fenwicksoftware.com.au:10260/BC/?company=Demo%20Data%206 Related work items: microsoft#27654
|
We've been receiving some push back on the demo data PRs. Will ask for a review by the team behind the demo data tool before processing. |
Apps/W1/ContosoCoffeeDemoDataset/app/DemoData/Analytics/AnalyticsModuleSetup.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/ContosoCoffeeDemoDataset/app/DemoData/Analytics/AnalyticsModuleSetup.Table.al
Outdated
Show resolved
Hide resolved
...feeDemoDataset/app/DemoData/Analytics/3.Transactions/CreateExtendedPurchDocument.Codeunit.al
Outdated
Show resolved
Hide resolved
...oCoffeeDemoDataset/app/DemoData/Analytics/4.Historical/CreatePostedAnalyticsData.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/ContosoCoffeeDemoDataset/app/DemoTool/ContosoCoffeeDemoDataSetup.Table.al
Outdated
Show resolved
Hide resolved
...feeDemoDataset/app/DemoData/Analytics/3.Transactions/CreateExtendedPurchDocument.Codeunit.al
Outdated
Show resolved
Hide resolved
|
@haoranpb Just checking in to see whether you have any more feedback on this PR? Thank you |
|
Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed. |
Apps/W1/ContosoCoffeeDemoDataset/app/DemoTool/ContosoDemoDataModule.Enum.al
Outdated
Show resolved
Hide resolved
|
@ayrtonmassey Could you review this PR please? Thank you |
|
@tuan-nguyen-fenwick I'm not sure why I was added to this PR, I have removed myself. Looks like you have some comments from @JesperSchulz to resolve? |
|
Please disregard the random assignment of code reviewers. Not sure why GitHub does that. @WaelAbuSeada, we need your review of this one. |
...feeDemoDataset/app/DemoData/Analytics/3.Transactions/CreateExtendedPurchDocument.Codeunit.al
Outdated
Show resolved
Hide resolved
|
@WaelAbuSeada I have addressed build issues in IT:
|
|
@Aleyenda Just confirming, aside from resolving the merge conflicts, is there anything else needed on this PR? From what I understand, this change is already released in v27.2, so can we go ahead and close it? |
Update: I have resolved merge conflicts. |
|
@attilatoury I have checked and this PR seems to be released in v27 already. Should I be closing this PR or what will be the next step? |
|
@tuan-nguyen-fenwick We usually merge the new changes both in main and in the relevant release branches (main should not be behind). |
|
The changes are actually in the main branch but not in the 27.x one. I will backport them and then close this PR. |
JesperSchulz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes have been merged internally already and synced. This PR now hence appears empty.

Summary
Work Item(s)
Fixes #28859
Fixes: AB#580998