Skip to content

Conversation

@aholstrup1
Copy link
Collaborator

@aholstrup1 aholstrup1 commented Jan 28, 2026

❔What, Why & How

Currently
Apps defined in the installApps and installTestApps settings can either refer to files in the file system or URLs to files. If a URL is defined, then the Runpipeline action will check that the URL is reachable and Run-ALPipeline (in BCContainerHelper) will download the apps.

Proposed Change
We move the download of these apps to the "Download Project Dependencies" action. That way most dependencies should be downloaded to the runner before calling Run-ALPipeline. This action would still not resolve dependencies from NuGet. That's something we should add in the future.

Related to AB#618073

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry

@aholstrup1 aholstrup1 requested a review from a team as a code owner January 28, 2026 10:45
Copilot AI review requested due to automatic review settings January 28, 2026 10:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request moves the downloading of apps specified in installApps and installTestApps settings from the RunPipeline action to the DownloadProjectDependencies action. This improves error detection and build reliability by downloading dependencies upfront before the build pipeline runs.

Changes:

  • Added functionality to DownloadProjectDependencies action to download app files from URLs in installApps/installTestApps settings
  • Removed URL validation and secret resolution logic from RunPipeline action
  • Updated RELEASENOTES.md to document the new behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
RELEASENOTES.md Documents the new behavior where URL-based dependencies are downloaded during the DownloadProjectDependencies action
Actions/DownloadProjectDependencies/DownloadProjectDependencies.Action.ps1 Adds two new functions: Get-AppFileFromUrl for downloading files with retry logic, and DownloadDependenciesFromInstallApps for processing installApps/installTestApps settings
Actions/RunPipeline/RunPipeline.ps1 Removes secret resolution and URL validation logic for installApps/installTestApps, now relies on JSON files from DownloadProjectDependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mazhelez
mazhelez previously approved these changes Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants