Skip to content

Conversation

@freddydk
Copy link
Contributor

@freddydk freddydk commented Jan 27, 2026

❔What, Why & How

Deliver to AppSource will try to submit all projects to AppSource even though no ProductId is defined and hence fail when library projects exists

Related to issue: #2095

Fixes #2095

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry

@freddydk freddydk requested a review from a team as a code owner January 27, 2026 07:06
Copilot AI review requested due to automatic review settings January 27, 2026 07:06
@freddydk
Copy link
Contributor Author

@microsoft-github-policy-service agree

@freddydk freddydk changed the title Fixes 2095 deliverToAppSource.ProductId needs to be specified (Library app) Jan 27, 2026
@freddydk
Copy link
Contributor Author

@fvet feel free to update AL-Go system files with freddydk/AL-Go@issue2095 and see whether this fixes the issue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes issue #2095 where the "Publish to AppSource" action fails when library projects exist in a multi-project repository without a deliverToAppSource.ProductId defined. The fix allows the action to skip library projects instead of throwing an error, enabling users to use wildcards ('*') to deliver all AppSource-enabled projects without manually excluding library projects.

Changes:

  • Modified the delivery logic to skip projects without a ProductId instead of failing
  • Added a check to detect library projects early in the AppSource delivery flow
  • Updated release notes to document the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
Actions/Deliver/Deliver.ps1 Added early check to skip projects without ProductId; removed the later error throw that was preventing library projects from being gracefully skipped
RELEASENOTES.md Added entry documenting the fix for issue #2095

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

freddydk and others added 2 commits January 27, 2026 08:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aholstrup1 aholstrup1 enabled auto-merge (squash) January 28, 2026 06:46
@aholstrup1 aholstrup1 closed this Jan 28, 2026
auto-merge was automatically disabled January 28, 2026 07:26

Pull request was closed

@aholstrup1 aholstrup1 reopened this Jan 28, 2026
@aholstrup1 aholstrup1 enabled auto-merge (squash) January 28, 2026 07:26
@freddydk
Copy link
Contributor Author

@microsoft-github-policy-service agree

@aholstrup1 aholstrup1 disabled auto-merge January 28, 2026 07:37
@aholstrup1 aholstrup1 merged commit 57c2b2d into microsoft:main Jan 28, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: deliverToAppSource.ProductId needs to be specified (Library app)

3 participants