refactor(mcp): describe schemas; keep search and checkout listed - #64
Merged
Merged
Conversation
HOW belongs on the JSON Schema after short tool prose. Checkout is how you get a key, so it registers without MICROLINK_API_KEY; search needs a key, so it registers when one is set. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 35228153674Warning No base build found for commit Coverage: 80.92%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Hiding search when no API key kills the buy funnel: the model never picks the tool, never hits the missing-key error, never suggests checkout. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Did not merge
video/videosor split billing into another package.Test plan
pnpm --filter @microlink/mcp testMICROLINK_API_KEYand confirm bothmicrolink_searchand checkout tools are listedmicrolink_screenshotinput schema forfullPage/devicedescriptionsmicrolink_searchwithout a key and confirm the model can route to checkoutNote
Low Risk
Documentation and schema metadata only; no runtime API or auth logic changes in the diff.
Overview
Moves how-to-use detail into MCP input JSON Schema by adding Zod
.describe()text across screenshot/PDF, shared browser/visual options, content/collection tools, embed, Lighthouse, search, and function inputs—so agents can read field docs viamicrolink_docs/schema instead of long tool blurbs.Search + API key funnel: default server instructions and the
microlink_searchtool text now say search requires an API key and to use checkout tools when the key is missing (aligned with keeping search visible alongside checkout).CLI:
--animatedhelp now says it captures a short MP4/WebM video instead of a still (not GIF-focused wording).Tests: assert screenshot schema exposes
fullPagedescriptions in JSON Schema; stdio-server expectations updated for the new instruction wording.Reviewed by Cursor Bugbot for commit 837e71b. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
fullPageoption.