Add support for loading snapshots and update IGamesCallbacks and IGam… - #3795
Open
NepMods wants to merge 1 commit into
Open
Add support for loading snapshots and update IGamesCallbacks and IGam…#3795NepMods wants to merge 1 commit into
NepMods wants to merge 1 commit into
Conversation
…esService interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Games: Fix snapshot transaction codes so game data (cloud saves) works
Evidence
Transaction codes were extracted from the real Play Games SDK
AAR(
com.google.android.gms:play-services-games) via the AIDLStubonTransactswitch and the client callback implementations, and cross-checked against two SDK
revisions:
onSnapshotsLoaded(DataHolder)onResolveSnapshotHead(DataHolder, Contents)commitSnapshotResult(DataHolder)getSelectSnapshotIntent(...)loadSnapshots(...)commitSnapshot(...)discardAndCloseSnapshot(Contents)resolveSnapshotHead(...)The callback mapping is confirmed by the client implementations, e.g.
zzbi.zzt(DataHolder)(12001) buildsAnnotatedData<SnapshotMetadataBuffer>,zzbv.zzs(DataHolder, Contents)(12004) handles snapshot open, andzzag.zzp(DataHolder)(12005) builds aSnapshotMetadatacommit result.Changes
play-services-games/.../IGamesCallbacks.aidlonSnapshotsLoaded(in DataHolder data) = 12001.onResolveSnapshotHead→12004andcommitSnapshotResult→12005.play-services-games/.../IGamesService.aidlplay-services-core/.../games/GamesService.ktloadSnapshots(): request thegames_lite+ Drive appfolder token,fetch snapshots via
SnapshotsDataClient.loadSnapshotData(), build aDataHolderover the player/game/snapshot columns, and deliver it viaonSnapshotsLoaded(failure returns a non-OK status holder).resolveSnapshotHead()'sDataHolder(id, unique name, title/description, timestamp, duration, progress, device,
cover image) instead of returning only the player row.
discardAndCloseSnapshot()now closes theContentsfile descriptor.