Rationalise deps - #36
Draft
bobular wants to merge 2 commits into
Draft
Conversation
Contributor
|
yea spieceasi needed moving and i missed it i guess. can sort that once there is a plan for the future relationship of the two utils packages. in the meantime, i wonder about the maaslin install, the ci still doesnt seem happy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR is provisional based on adding
to mbioUtils/DESCRIPTION
I'm pretty sure this is where the dependency should be declared, not here.
However. I'm going to avoid the whole mbioUtils/veupathUtils clash of the titans for now.