Skip to content

NIDAQ: Make Voltage property sequenceable.#959

Merged
nicost merged 2 commits into
micro-manager:mainfrom
nicost:NiDAQAOSequence
Jun 5, 2026
Merged

NIDAQ: Make Voltage property sequenceable.#959
nicost merged 2 commits into
micro-manager:mainfrom
nicost:NiDAQAOSequence

Conversation

@nicost

@nicost nicost commented Jun 5, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NIDAQ Analog Output Port “Voltage” property handler to support Micro-Manager property sequencing (querying sequenceability, loading a sequence, and starting/stopping sequence execution).

Changes:

  • Implements MM::IsSequenceable for the Voltage property based on hub sequencing support and max sequence length.
  • Adds support for MM::AfterLoadSequence to parse and load a voltage sequence into the adapter’s DA sequence buffer.
  • Adds MM::StartSequence / MM::StopSequence handling to start and stop the AO sequence.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DeviceAdapters/NIDAQ/NIAnalogOutputPort.cpp
Comment thread DeviceAdapters/NIDAQ/NIAnalogOutputPort.cpp
Comment thread DeviceAdapters/NIDAQ/NIAnalogOutputPort.cpp
@nicost nicost merged commit 86dd7f7 into micro-manager:main Jun 5, 2026
2 checks passed
@nicost nicost deleted the NiDAQAOSequence branch June 5, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants