snippets: allow escaped shell vars like ${\1:?foo}#23
Open
AndrewDDavis wants to merge 1 commit intomicro-editor:masterfrom
Open
snippets: allow escaped shell vars like ${\1:?foo}#23AndrewDDavis wants to merge 1 commit intomicro-editor:masterfrom
${\1:?foo}#23AndrewDDavis wants to merge 1 commit intomicro-editor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The syntax for snippet placeholders is identical to some shell parameter expansions of the positional arguments in a script. If you want to put such shell expansions in a snippet, the snippet is mangled when it's inserted.
This PR fixes the problem by allowing shell snippets to have a syntax like
${\1:?message}, which doesn't match the pattern from snippet placeholders. After the code for identifying snippet placeholders is run, this call togsubstrips the backslash from the parameter expansion to produce the code that was actually intended.