Open
Conversation
numpy 1 not support python >= 3.13 and from [link](microsoft/onnxruntime#21063 (comment)) onnxruntime>=1.19.0 (released August 2024) is compatible with numpy>=2.0.0. and we have already pin onnxruntime to 1.19. So I think we can unpin numpy now
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Updates numpy dependency constraints in libs/infinity_emb/pyproject.toml to support Python 3.13 compatibility by allowing numpy >= 2.0.
- Modified numpy version constraint from
>=1.20.0,<2to>=1.20.0since onnxruntime >= 1.19.0 is compatible with numpy 2.0 - Change is backwards compatible as the lower bound of
>=1.20.0remains unchanged
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Collaborator
|
Nice, we should probably also extend the tests to cover 3.13 then |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy 1 do not support python >= 3.13
and from link onnxruntime>=1.19.0 (released August 2024) is compatible with numpy>=2.0.0.
and we have already pin onnxruntime to 1.19.
So I think we can unpin numpy now
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.