Conversation
There was a problem hiding this comment.
PR Summary
This PR updates the Docker build configurations across multiple Dockerfiles to standardize dependency management for the nomic-ai/nomic-embed-text-v1.5 model support.
- Replaces git-based transformers installation with pinned version 4.50.3 across all Dockerfiles (amd, nvidia, cpu, trt_onnx)
- Adds colpali-engine 0.3.9 as a direct pip install, removing git dependency
- Removes cleanup commands in nvidia_auto which may impact image size optimization
- TODO comment remains in cpu_auto Dockerfile that should be addressed
- Version pinning could potentially limit compatibility with other models requiring different versions
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -47,7 +47,7 @@ RUN poetry install --no-interaction --no-ansi --extras "${EXTRAS}" --without li | |||
| RUN poetry run $PYTHON -m pip install --no-cache-dir https://github.com/Dao-AILab/flash-attention/releases/download/v2.7.4.post1/flash_attn-2.7.4.post1+cu12torch2.6cxx11abiFALSE-cp310-cp310-linux_x86_64.whl | |||
There was a problem hiding this comment.
logic: flash-attention wheel is pinned to Python 3.10 and CUDA 12, but there's no explicit Python version check
| RUN poetry run $PYTHON -m pip install --no-cache-dir https://github.com/Dao-AILab/flash-attention/releases/download/v2.7.4.post1/flash_attn-2.7.4.post1+cu12torch2.6cxx11abiFALSE-cp310-cp310-linux_x86_64.whl | |
| RUN if [ "$($PYTHON --version 2>&1)" != "Python 3.10"* ]; then echo "Error: Python 3.10 is required for flash-attention wheel" && exit 1; fi && \ | |
| poetry run $PYTHON -m pip install --no-cache-dir https://github.com/Dao-AILab/flash-attention/releases/download/v2.7.4.post1/flash_attn-2.7.4.post1+cu12torch2.6cxx11abiFALSE-cp310-cp310-linux_x86_64.whl |
| # TODO: remove this line | ||
| RUN apt-get install --no-install-recommends -y git && poetry run python -m pip install git+https://github.com/huggingface/transformers.git@7547f55e5d93245c0a013b50df976924f2d9e8b0 && rm -rf ~/.cache/ /tmp/* | ||
| RUN poetry run pip install --no-cache-dir transformers==4.50.3 colpali-engine==0.3.9 |
There was a problem hiding this comment.
style: consider using poetry to manage these dependencies instead of direct pip install to maintain consistent dependency management
| # TODO: remove this line | ||
| RUN apt-get install --no-install-recommends -y git && poetry run python -m pip install git+https://github.com/huggingface/transformers.git@7547f55e5d93245c0a013b50df976924f2d9e8b0 && rm -rf ~/.cache/ /tmp/* | ||
| RUN poetry run pip install --no-cache-dir transformers==4.50.3 colpali-engine==0.3.9 |
There was a problem hiding this comment.
style: TODO comment indicates this line should be removed, but it's being modified instead. Consider removing the line entirely or removing the TODO if the line is now permanent.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 79.85% 79.75% -0.10%
==========================================
Files 43 43
Lines 3489 3498 +9
==========================================
+ Hits 2786 2790 +4
- Misses 703 708 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.