feat: add Windows native binary support#294
Open
rodttu02-vu wants to merge 6 commits intomia-platform:mainfrom
Open
feat: add Windows native binary support#294rodttu02-vu wants to merge 6 commits intomia-platform:mainfrom
rodttu02-vu wants to merge 6 commits intomia-platform:mainfrom
Conversation
Author
|
Hi team — friendly ping on this one. Happy to address any feedback or answer questions. The PR adds a native Windows binary to eliminate the WSL dependency for Windows users. Thanks for your time! |
Author
|
Hey team — it's been a week with no feedback on this one. This is a pretty minimal change (66 lines, no modifications to existing code) that unblocks Windows users from needing WSL entirely. Would love even a quick "looks good" or "here's what we'd need changed." Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_windows.go— the missing Windows implementation ofopenBrowser(usingrundll32 url.dll,FileProtocolHandler), matching the pattern of the existingbrowser_darwin.goandbrowser_linux.go.github/workflows/release-windows.yaml— cross-compilesmiactl.exe(windows/amd64) on every push tomainand publishes it as a rolling pre-release taggedlatest-windowsusing onlyGITHUB_TOKENWhy
miactlhas no official Windows binary. Teams running on Windows currently work around this with WSL, which adds friction and a hard dependency on a Linux subsystem. A native binary removes that dependency entirely.The release workflow intentionally avoids the upstream Goreleaser/Homebrew machinery (which requires
BOT_GITHUB_TOKEN) and instead uses a simple rolling pre-release so the latest build is always available via:Changes
internal/authorization/browser_windows.goopenBrowserimplementation.github/workflows/release-windows.yamlTest plan
release-windowsworkflow runs green on mergelatest-windowspre-release appears withmiactl.exeassetmiactl --versionto confirm it executes natively on Windowsmiactl auth loginto exercise theopenBrowserpath on Windows