fix: Validate restored sessions and fix inline preview autocmd leak#37
Merged
Conversation
Restore now type-checks each stored item (uri string, range table) and isolates per-item restoration in pcall so a single corrupt entry no longer aborts the whole session. Only items that actually produce a popup count as restored, so the skipped-item warning, PeekstackRestore item_count, and on_done result reflect the real outcome. normalize_range becomes the validation chokepoint for untrusted data, coercing corrupt range/position shapes to safe defaults instead of crashing downstream.
close() now deletes the PeekstackInlinePreview augroup so the remaining `once` close-event autocmds are disarmed when one of them fires, instead of staying armed and triggering close on unrelated later activity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_rangeas the validation chokepoint for untrusted data, coercing corrupt ranges to safe defaultsonceclose-event autocmds stayed armed afterclose()Changes