Open
Conversation
Author
|
ping @mgattozzi |
mgattozzi
force-pushed
the
main
branch
10 times, most recently
from
c5614a4 to
60790a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new argument
ignoreto the attribute macro, which expands into an#[ignore]attribute on the generated test function. A minimal test for this functionality is included, but no tests for the interaction with other arguments or features yet.Additionally, this PR includes attributes specified on the input function in the generated test function. If you'd like, I can break this functionality out into its own PR.
With the second change, it should also be possible to remove the first change and deprecate the
should_panicargument in favor of specifying#[ignore]or#[should_panic]directly.Fixes #12