fix: Add automated end-to-end testing using playground in CI/CD workflows#49
Open
mfogliatto wants to merge 10 commits into
Open
fix: Add automated end-to-end testing using playground in CI/CD workflows#49mfogliatto wants to merge 10 commits into
mfogliatto wants to merge 10 commits into
Conversation
Adds a PowerShell test runner (Run-E2ETests.ps1) that validates all three ReferenceCop rule types (AssemblyName, ProjectTag, ProjectPath) plus a valid-build scenario. Integrates into both PR and official build workflows. New test projects: InternalLib, ToolsProject, ValidApp provide test fixtures for the ProjectPath, ProjectTag, and valid-build scenarios respectively. Fixes #43
In .NET 8, System.Web.HttpUtility is a legitimate shared framework assembly. The wildcard pattern System.Web* incorrectly flags it in ValidApp which has no actual System.Web dependency.
The System.Web assembly is part of the .NET 8 shared framework and appears as a reference in all net8.0 projects. Removed the rule from playground config since no test scenario exercises it. Changed NoNewtonsoftJson to Error severity to ensure scenario 1 build fails.
Scenarios 2 (ProjectPath) and 3 (ProjectTag) replace SampleApp.csproj to test different reference rules. The original Program.cs has 'using SampleLibrary' which causes CS0246 when SampleLibrary isn't referenced. Use a minimal Program.cs for these scenarios so the ReferenceCop analyzer can run without compilation errors.
The ToPath pattern was '**/Internal/**' but the actual test project directory is 'InternalLib', not 'Internal'.
The ProjectPathViolationDetector uses string.StartsWith() not glob matching. Paths are relative to ReferenceCopRepositoryRoot (the TestProject directory). Use simple prefix 'SampleApp' and 'InternalLib' to match the relative paths correctly.
Addresses review comment — pack should use Release, not Debug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automated end-to-end testing that validates ReferenceCop rule detection using the existing playground infrastructure, integrated into both PR and official build CI/CD workflows.
Changes
playground/Run-E2ETests.ps1— PowerShell test runner that exercises all three rule types plus a valid-build scenarioplayground/TestProject/InternalLib/— Test fixture for ProjectPath rule validationplayground/TestProject/ToolsProject/— Test fixture for ProjectTag rule validationplayground/TestProject/ValidApp/— Test fixture for valid (no-violation) scenario.github/workflows/pr-build.yaml— Added e2e test step after unit tests.github/workflows/official-build.yaml— Added e2e test step after unit testsplayground/TEST-SCENARIOS.md— Documents all test scenariosplayground/playground.slnx— Updated to include new projectsTesting
The test runner validates:
Run locally:
./playground/Run-E2ETests.ps1 -PackFirstFixes #43