Support alternate GNU getopt binary on OpenBSD#104
Open
0xkag wants to merge 1 commit into
Open
Conversation
OpenBSD getopt does not support `-l`. There's a gnugetopt port/package that is the GNU implementation (the one on Linux) that supports `-l`. So if gnugetopt is present in the PATH use that, otherwise `getopt`.
7 tasks
Collaborator
|
Hey Kyle, thanks for the PR! Is this the only instance in the program that has a GNU-specific implementation do you know, or are there others we need to be careful of? |
Contributor
|
Bump @0xkag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenBSD
getoptdoes not support-l. There's agnugetoptport/package that is the GNU implementation (the one on Linux) that supports-l. So ifgnugetoptis present in the PATH use that, otherwise usegetopt.This is coming from ohmyzsh/ohmyzsh#9677.