Fixes missing symbols in featomic when using fetch_metatensor#425
Fixes missing symbols in featomic when using fetch_metatensor#425MilitaoLucas wants to merge 2 commits intometatensor:mainfrom
Conversation
MilitaoLucas
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the vendored (FetchContent) metatensor-core version used by featomic’s CMake build, aiming to address missing-symbol issues tied to the fetched metatensor version.
Changes:
- Bump
METATENSOR_FETCH_VERSIONfrom0.1.17to0.1.19 - Update the corresponding
FetchContent_Declare(... URL_HASH ...)SHA256
| set(METATENSOR_FETCH_VERSION "0.1.19") | ||
| set(METATENSOR_REQUIRED_VERSION "0.1") |
There was a problem hiding this comment.
The PR title/description suggests fixing missing symbols when using older metatensor versions, but this change only bumps the version used when FEATOMIC_FETCH_METATENSOR=ON. If the missing-symbol issue also affects builds using find_package(metatensor ...) (i.e., system-provided metatensor), this won’t prevent selecting an older incompatible metatensor since METATENSOR_REQUIRED_VERSION is still just "0.1". Please clarify the scope in the PR description, or bump METATENSOR_REQUIRED_VERSION to the first known-good version so incompatible metatensor versions fail at configure time instead of at link/load time.
|
Thanks for the PR, this looks good. CI is broken for a different reason, I'm fixing it and then I'll merge this! |
I figured. That is fine. Thanks! |
|
I've included the fix from this PR directly in #426 |
|
That is fine. Thanks. |
This was found and fixed by @RealUranar.