Repository navigation
Conversation
… PolarsFilter is the first (ITL-1266) - PROVISIONAL_OPERATORS (core/operators/provisional.py) lists the operators whose identity is not frozen with data context v1; each also sets PROVISIONAL = True. Constructing one issues ProvisionalHashWarning once per operator per process and notes the use (utils/provisional.recording_provisional_uses). - The golden store gains provisional files, data/v1/provisional/<group>.json, listed in golden.provisional of the manifest, outside the history: no release freezes them. - A golden case declares the provisional operators it depends on; compute_group_kinds refuses a case that uses one without declaring it, and the golden test checks that every entry is in the kind of file its case declares. - generate_golden_hashes.py --relocate moved the 86 entries of the four PolarsFilter cases (polars_filter, polars_filter_expr, polars_filter_expr_job, polars_expr) from pipeline-01.json and semantic-01.json into the provisional files. No value changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 29 billable files and costs up to $7.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 53 minutes for your next included review. View limit details
|
The operators page lists the provisional operators and what is not guaranteed; the golden hash reference describes the provisional files, the placement check and how an operator leaves the group; hashing.md, RELEASING.md, the golden README, the generator header, CLAUDE.md and .zed/rules state the rule. Changelog fragment ITL-1266. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eywalker
marked this pull request as ready for review
November 18, 2026 22:27
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ITL-1266. Related: ITL-1247, ITL-1265.
What this does
Data context v1 freezes every hash at 0.4.0. Provisional operators are outside that freeze.
PolarsFilteris the first one.The list.
orcapod.operators.PROVISIONAL_OPERATORS(core/operators/provisional.py) maps each operator's name to the issue that decides its identity:{"PolarsFilter": "ITL-1247"}. Each listed operator also setsPROVISIONAL = Trueon its class. A test checks that the list and the markers agree.The warning. Building a provisional operator issues
ProvisionalHashWarningonce per operator per process, at construction (this coversstream.polars_filter). The text says what is not guaranteed: the operator's identity, and so the stored paths and record ids of its results and of everything downstream of it.The golden store. Provisional files live in
data/v1/provisional/<group>.json. The manifest lists them, each with its sha256, ingolden.provisional, outsidegolden.history. So no release revision lists them and--releasenever freezes them. The manifest pin excludesgolden, andscripts/check_golden_tags.pydoes not compare these files. Their values are still computed and checked on every run.The case declaration. A golden case declares the provisional operators it depends on:
@case(group, name, provisional=("PolarsFilter",)).compute_group_kindsruns each case while the library records which provisional operators it builds. It refuses a case that builds one without declaring it, and a case that declares a name that is not in the list. A golden test checks that every entry sits in the kind of file its case declares.The tool.
generate_golden_hashes.py --relocatemoves pinned entries, values copied unchanged, to the kind of file their case declares:--add,--checkand--removehandle provisional files too.The moved list: 86 entries, no value changed
pipeline-01.jsonprovisional/pipeline.jsonpolars_filter(9),polars_filter_expr(18),polars_filter_expr_job(49)semantic-01.jsonprovisional/semantic.jsonpolars_expr(10:polars_expr_v1; only PolarsFilter feeds it)Proof (
docs/dev/scripts/itl_1266_moved_entries.py origin/main):The diff of
pipeline-01.jsonandsemantic-01.jsononly deletes lines. The 21 entries ofpolars_filter_expr_jobthat do not depend on the filter (node[subjects],node[scans]) each have the identical value pinned in the frozenjobcase, so no frozen value is lost.Docs
docs/concepts/operators.mdhas a new section, Provisional operators: the list, what is not guaranteed, and the warning. The PolarsFilter section now carries a warning admonition.docs/reference/golden-hashes.mddescribes the provisional files, the placement check, and how an operator leaves the group.hashing.md,RELEASING.md, the golden README, the generator header,CLAUDE.mdand.zed/rulesare updated.changelog.d/ITL-1266.md.Open decision
The concept word ("provisional" or "experimental") is still with the developer. The word sits in few places. If "experimental" is chosen, everything is renamed in one mechanical commit, with no aliases. Follow-up, before 0.4.0: the six provisional logical types (119 golden entries) move to the same provisional files, using the same mechanism.
Merging with other golden PRs
This PR changes
pipeline-01.json,semantic-01.jsonand revision 0 ofv1.json, and so thepreviousanddigestof revision 1. A PR that also editsv1.json(#434, #441, #448, #449) will conflict there. Whichever PR lands second takesmain's golden files andv1.json, then re-runs its own tool steps (--relocatefor this one,--remove/--addfor the others). Never hand-merge digests. #448/#449 regenerate entries insidepolars_filter_expr_job;--remove/--addwork in the provisional files.🤖 Generated with Claude Code