Repository navigation
test(sources, function_pod, pipeline): several tags, keys, inputs and bound sources, in every order and role (ITL-1236, part 2) - #443
Conversation
…y order, role and arrangement (ITL-1236) A shared family of inputs with three tags and three data columns, in several tag orders, table layouts and role settings (plain, data-tags, mixed), and tests of every operator over it, sync and async: the result does not depend on the arrangement of the input; the order of a set argument (names, rename mappings, constraints) changes nothing; Join over 2, 3 and 4 inputs and MergeJoin are commutative; SemiJoin matches on every shared tag. Defects found are xfail(strict=True): ITL-1241 (MergeJoin ties), ITL-1242 (MapTags swap of data-tags), MergeJoin null crash (issue pending). The inventory of every several-item argument, with the evidence and the ranked gaps, is docs/dev/specs/itl-1236-several-item-test-audit.md. CLAUDE.md and .zed/rules state the rule in "Testing conventions". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… bound sources, in every order and role (ITL-1236) Sources: tag order and layout enter no hash; tag_only_columns order changes nothing; record ids follow the key order (content hash moves, pipeline hash and source id do not); tags_as_data order is the new columns' order only; CachedSource reads back every role and arrangement. Function pods: every order of three inputs gives the same rows, hashes and columns, and a job over another order finds every result stored, sync and async; parameters match by name; a function reads several data-tags in any arrangement. Bind: two sources in one call, one refused leaves both unbound; a source in another arrangement binds without moving anything. Defects found are xfail(strict=True) with the issue pending: the fall-through tags' order in a function pod's identity (defect 6), swapped output_keys keep the uri (defect 4), a mixed-role source in another order breaks the bound node's table (defect 5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 8 billable files and costs up to $2.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 9 minutes for your next included review. View limit details
|
…se; MergeJoin and the restricted SemiJoin in every layout (ITL-1236) Addresses the Copilot review of #442. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…' into eywalker/itl-1236-part2-sources-pods-bind
…; predicates in every order and role, sync and async (ITL-1236) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…' into eywalker/itl-1236-part2-sources-pods-bind # Conflicts: # docs/dev/specs/itl-1236-several-item-test-audit.md
There was a problem hiding this comment.
🟡 Changes recommended
The tests can pass despite partial source rebinding or identical hashes and cache addresses for reordered keys, leaving both behaviors insufficiently verified.
2 open issues
What changed in this PR
Extends the ITL-1236 test audit to sources, function pods, and pipeline binding, building on the operator coverage from #442. No library code or golden values change.
Changes:
- Adds source tests for tag roles, column arrangements, key ordering, and cached reads.
- Tests multi-input function pods, stored-result reuse, and multi-source binding, including sync and async execution.
- Records coverage and known defects, with strict expected-failure tests for deferred fixes.
| File | Description |
|---|---|
tests/test_pipeline/test_bind_several_items.py |
Tests multiple bindings, atomic rejection, and column arrangements. |
tests/test_core/sources/test_several_items.py |
Tests source ordering, roles, record keys, and caching. |
tests/test_core/operators/test_several_items.py |
Inherited from #442: operator ordering and role coverage. |
tests/test_core/operators/several_items.py |
Inherited from #442: shared sources and comparison helpers. |
tests/test_core/function_pod/test_several_items.py |
Tests input permutations, parameter matching, and result reuse. |
docs/dev/specs/itl-1236-several-item-test-audit.md |
Updates the coverage inventory and deferred-defect notes. |
CLAUDE.md |
Inherited from #442: several-item testing guidance. |
.zed/rules |
Inherited from #442: matching testing guidance for Zed. |
Review effort: Balanced
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…' into eywalker/itl-1236-part2-sources-pods-bind
…arrangement; defect 7 as xfail (ITL-1236) Addresses the second Copilot review of #442: sync and async rows are compared with their column order, system-tag order and Arrow schemas within each arrangement, and a result's keys with its rows' keys. Both fail on inputs whose table layout differs from the tag order (reported, issue pending); those combinations are xfail(strict=True), the others are asserted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…' into eywalker/itl-1236-part2-sources-pods-bind # Conflicts: # docs/dev/specs/itl-1236-several-item-test-audit.md # tests/test_core/operators/several_items.py
…th bound sources (ITL-1236) Addresses the Copilot review of #443. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…de stores one column order on both orchestrators (ITL-1236) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…' into eywalker/itl-1236-part2-sources-pods-bind # Conflicts: # docs/dev/specs/itl-1236-several-item-test-audit.md
There was a problem hiding this comment.
🟡 Changes recommended
The tests leave reordered-input async execution and persisted-cache readback unverified, while symmetric outputs allow incorrect parameter binding to go undetected.
4 open issues
2 resolved since last review
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
…ere ITL-1249 reproduces (ITL-1236) Addresses the third Copilot review of #442. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…' into eywalker/itl-1236-part2-sources-pods-bind
…ements, cache-only readback, bind on both orchestrators (ITL-1236) Addresses the second Copilot review of #443. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge order: #442, then #443, then #444. All three target
main; each contains the previous one's commits. After one is merged,mainis merged into the next (never a rebase), so its diff shrinks to its own files.Part 2 of ITL-1236 (sources, function pods, binding). Stacked on #442: this branch contains #442's commits (merged in, no rebase); until #442 is merged, review only the files below (
tests/test_core/sources/,tests/test_core/function_pod/,tests/test_pipeline/test_several_items.py/test_bind_several_items.py, and thefingerprint(source_info=)option inseveral_items.py).What (tests only, public interface)
tests/test_core/sources/test_several_items.pytag_columnsin every order and layout (plain, data-tags, mixed): keys follow the tag order; rows, record ids, system tags, content and pipeline hashes do not change.tag_only_columnsin two orders: no change.record_id_columnswith two and three key columns (tag and data roles) in several orders: each record id is the canonical JSON of the keys in key order; another order moves the content hash, not the pipeline hash or the source id; a set is refused.DerivedSource(tags_as_data=)with two entries, both orders: only the new columns' order changes.CachedSourceover a source of each role and arrangement reads back as the source.tests/test_core/function_pod/test_several_items.pypod(a, b, c)in all six input orders: same rows, hashes and columns; extra data columns dropped by the automatic select; parameters matched by name (parameter order differs from column order).tests/test_pipeline/test_bind_several_items.pydocs/dev/specs/itl-1236-several-item-test-audit.md) records what part 2 checked.Defects found (not fixed here;
xfail(strict=True))test_the_tag_order_of_the_input_does_not_change_a_fall_through_pods_hashestest_swapped_output_keys_are_another_functionoutput_keyskeep the function's uri; a job then serves one's stored values under the other's names.test_a_mixed_role_source_in_another_arrangement_is_bound_as_the_slot_declaresbind, and the source node's table then repeats a column (KeyError).No library code changes; no golden changes; no changelog fragment (tests and developer docs only).
Related: ITL-1236 (part 2 of several; the last PR closes it), ITL-1244, ITL-1245, ITL-1246.
Posted by a Claude Code agent on behalf of @eywalker.
🤖 Generated with Claude Code