Repository navigation
refactor!: rename the remaining public store names to database (ITL-1087) - #397
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…es (ITL-1087) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ITL-1087 Rename the remaining public "store" names to "database": set_ephemeral_database, OrcapodDatabaseError and its family
OverviewFollow-up of ITL-1082 (PR #368), which renamed The rename touches about 54 files, so it is its own pull request, run after the other pre-tag pull requests merge. Goals & Success Criteria
Scope & BoundariesIn scope:
Out of scope:
ITL-1147 PipelineJob.set_ephemeral_store raises AttributeError on a job with a side-effect node
Overview
Goals & Success Criteria
Scope & BoundariesIn scope:
Resources & References
|
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 40 minutes. View limit details
|
…ame-the-remaining-public-store-names-to
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@coderabbitai review Posted by a Claude Code agent on behalf of @eywalker. |
Action not completed
|
|
CodeRabbit CLI review, run 1 of 1 ( Posted by a Claude Code agent on behalf of @eywalker. |
Fixes ITL-1087
Mechanical rename, no behaviour change. No alias or re-export of an old name.
Renames
set_ephemeral_store(store)->set_ephemeral_database(database)(pipeline, nodes, protocols); attributeephemeral_result_store->ephemeral_result_database;_ephemeral_store_in_use->_ephemeral_database_in_useStoreError->OrcapodDatabaseError,StoreWriteError->OrcapodDatabaseWriteError,StoreReadError->OrcapodDatabaseReadError;SideEffectLogDataContextErrorkeeps its nameStoreContentWarning->OrcapodDatabaseContentWarning(coordinator's choice, following theOrcapodDatabase*family prefix)describe_store_table->describe_database_table;store_path->database_path;utils/store_errors.py->utils/database_errors.py(store_error_of,keep_store_error,_no_store_error,_single_store_error... follow)changelog.d/ITL-1087.mdwith each rename and its migration. One.basedpyright/baseline.jsonrange moved by the longer identifier (same diagnostic,pipeline/base.py).No hash, path or saved-file change
None of the renamed names is a hash input, saved-file key, column or path (checked by grep; golden files and
test_hash_label_rule.pyuntouched, and they pass).'store' names deliberately kept
ResultCache.store(...)and its callers: a verb.bindings.store/bindings.get("store")inPipelineJob.load: the old saved-file key, read only to refuse it (ITL-1082)._compute_and_store(store=...)inoperator_node.py: a boolean flag meaning "write the output", a verb.run_summary.py): rendered output, not an identifier; left to avoid changing displayed text.stored_*,_stored_*,Stored*,not_stored,restore*: stored data in general.store on the node) andKV storein the SpiralDB connector.TestCallbackFailureKeepsStoreError,TestFlushRaisesStoreErrorsThemselves) and local variables (ephemeral_store,store) in tests.superpowers/,docs/metamorphic/plans/,CHANGELOG.mdand earlierchangelog.d/fragments: history, left alone.Verification
loaded_side_effects.py:346, which is on main at a899d1e (fix(pipeline): a loaded job keeps its side-effect nodes, read-only (ITL-1094) #381 x feat(pipeline): a run checks each source for new data first (ITL-1102) #384) and has a hotfix coming; none from this PR.CodeRabbit CLI review (pre-push gate), commit b449a6a + 4eb8877
3 findings, all declined as not caused by this rename:
pipeline/base.py:160side-effect nodes reachset_ephemeral_database: now fixed in this PR as ITL-1147 (the pipeline setter skips side-effect nodes; tests for live and loaded jobs).design_issues/ITL-884-DR1.mdconflicting flush() description: pre-existing text, only the names changed.docs/concepts/arrays.mdlist-tables exception: pre-existing text, only the names changed.ITL-1147 and second CLI review (commit 22a42d2 + merge of origin/main)
Fixes ITL-1147. 2 findings: (1) minor
design_issues/ITL-904-PJLOAD1.md:29stalestore=keyword: fixed in 7f2e47f. (2) minordocs/concepts/arrays.md:40list-tables exception: declined, pre-existing text, only names changed here.🤖 Generated with Claude Code