Repository navigation
fix(pipeline): loaded side-effect node passes run_alone the unchecked source ids (#381 x #384) - #396
Conversation
ITL-1094 A loaded job has no side-effect nodes: PipelineJob.load drops them
OverviewFound on November 13, 2026 by the ITL-1091 worker on A job with a side-effect pod node saves that node (the saved file has an entry with So a loaded job silently lacks its side-effect nodes: they cannot be inspected, and whatever is downstream of one is connected to something else or to nothing (to be established). Goals & Success Criteria
Scope & BoundariesIn scope:
Out of scope:
ITL-1102 A run checks each source for new data first: polling sources poll, table-backed sources check and reload; a failed check warns
OverviewSplit out of ITL-1095 (PR #380) on November 14, 2026, by the developer's instruction not to grow that pull request further ("let's stop bloating 380. Any new aspects should just become new issues"). ITL-1095 makes
Goals & Success Criteria
Scope & BoundariesIn scope:
Out of scope: Dependencies & Risks
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
PR #384 (ITL-1102) changed
run_job_node'srun_aloneto take the run's unchecked source ids (a tuple). PR #381 (ITL-1094), merged earlier, still passedlambda: self._run_alone(load_only=True)fromLoadedSideEffectJobNode.run: a basedpyright error on main (reportArgumentType), and aTypeErrorif reached (a loaded node whose upstream is not a job node). It now takes the ids and ignores them, as the liveSideEffectJobNode.rundoes. A regression test builds a loaded node over a source's stream and runs it load-only, which reachesrun_alone.Refs ITL-1094, ITL-1102
🤖 Generated with Claude Code
Summary by CodeRabbit