Skip to content

feat(store): find tables written before v0.3 by name, so side-effecting nodes fail on a v0.2 store (ITL-954) - #318

Closed
eywalker wants to merge 38 commits into
mainfrom
eywalker/itl-954-find-tables-written-before-v03-by-scanning
Closed

eywalker wants to merge 38 commits into
mainfrom
eywalker/itl-954-find-tables-written-before-v03-by-scanning

Conversation

@eywalker

Copy link
Copy Markdown
Contributor

Stacked on #313 (which is stacked on #309)

Fixes ITL-954

Summary

Only the commits after 8b050710 belong to this PR; the rest is #313 and #309.

#313 looks for a table of an earlier version at the node's own path with an older layout component. The other v0.3 changes (ITL-945, ITL-935, ITL-942) move every pipeline hash and function uri, so a real v0.2 table is at a path v0.3 never computes: nothing would be reported and side-effecting nodes would deliver again. This PR finds those tables by name.

  • list_table_paths(prefix=()) on ArrowDatabaseProtocol (public protocol addition, confirmed by the developer): the sorted paths of the tables under a path prefix, nested tables included, without opening a table. A store that cannot enumerate raises the new orcapod.errors.TableListingNotSupportedError.

    Database What it lists
    InMemoryArrowDatabase every table, flushed or pending, exactly
    DeltaTableDatabase, local every flushed table, exactly. A directory walk that goes on below a table (v0.1 bare tables have pdb_v1 under them; odb_v1/sdb_v1 sit under a v0.2 table) and never enters _delta_log
    DeltaTableDatabase, s3:// / s3a:// the same walk through s3fs (already a dependency), one LIST request per directory; credentials, endpoint and region are translated from the deltalake storage options, nothing else
    DeltaTableDatabase, gs:// / az:// / abfs:// only if the matching fsspec package is installed and reaches the store with its default credentials; otherwise it cannot list
    ConnectorArrowDatabase (SQLite, PostgreSQL, SpiralDB) by table name: names starting with the name the prefix maps to. Components after the prefix come back sanitized (: and . as _), a component holding __ comes back as two, and a different path with the same sanitized beginning is matched too. The last component (the layout) is exact
    ExtensionAwareDatabase what the wrapped database lists
    NoOpArrowDatabase nothing
  • Old versus current is decided by layout, not by hash (contexts/stored.CURRENT_LAYOUTS): under <function>/, side_effect_function/<function>/ or side_effects/<pod>/ (and the same below _result/), a table whose last component is not pdb_v2, rdb_v2, tdb_v2, odb_v1 or sdb_v1 was written before v0.3.

  • Side-effecting nodes of both kinds (SideEffectPod, function pods with ctx_arg) raise SideEffectLogDataContextError naming every table, before anything is delivered. The check for rows of another data context in the current table and the sibling-path check stay.

  • Ordinary function nodes report the tables in one warning per node. PipelineJob.run() reports one total per run of the old tables under the job that no node claims by name: operator caches, cached sources stored under the job, nodes that left the job. A CachedSource without an explicit cache_path also looks under <cache_path_prefix>/source/.

  • A store that cannot list its tables (developer's decision, November 11): a side-effecting node logs one warning that it could not check, and proceeds. No setting.

Accepted false positives

They err towards failing, and the error names the tables so the user can tell: an old table of another function or pod with the same name in the same job, and of another node of the same function. Pinned in TestTablesCountedByNameAlone.

Cost

  • Per node: one listing under its name. Measured on a local Delta-shaped store with 4000 tables (18000 directories): 0.25 ms.
  • Per job run: one listing of everything under the job. Same store: 0.3 s (measured while the test suite was running).
  • S3: one LIST request per directory, about 4.5 per table under the listed prefix, sequential. Not measured: no Docker on the worker machine, so the MinIO test (test_s3_lists_tables_and_nested_tables) did not run locally; the cloud walk itself is tested against a local directory standing in for the bucket.
  • Connector stores: one catalog query per listing. Tables found by listing are not read, so they are reported without a number of rows.

Tests on real v0.2 bytes

tests/test_arrays/data/v02_full_store.tar.gz (34 KB) was written by Orcapod v0.2.0 installed from the tag with its own pins; generator tests/test_arrays/data/make_v02_full_store.py, pods in tests/test_arrays/v02_full_store_pods.py. Nine tables: 3 pdb_v1, 3 rdb_v1 (two function pods and one ctx_arg pod), tdb_v1 (a sink), a bare operator cache (cache_mode=LOG), a bare cached source. The existing fixture is untouched.

tests/test_pipeline/test_pre_v03_tables.py runs the same job under this version on that store twice: as written, and with every hash in its paths replaced on disk, which is what the combined stack sees. Before the fix, with replaced hashes the sink and the ctx_arg pod delivered again (24 tests failed); now they raise, nothing is delivered, and the v0.2 files stay byte-identical. Sync and async.

Re-verification after the hash-moving branches are combined (the as_written cases then exercise real moved hashes):

uv run pytest tests/test_pipeline/test_pre_v03_tables.py tests/test_databases/test_list_table_paths.py -v

Differences from the approved plan

  • The "cannot list" warning names the path where tables would have been looked for (it holds the pod or function name), not the node label; one warning per node covers its pipeline and result prefixes.
  • A listing that fails on cloud storage counts as "cannot list" (warn and proceed), not as StoreReadError: s3fs may not get the credentials deltalake has. A failed local directory listing raises StoreReadError.

Known limits

Listed in DESIGN_ISSUES.md (DC2). In short: on a connector store a table found both at the sibling path and by listing is named twice; the job total needs a positive mark (pdb_v1/rdb_v1/tdb_v1, or a last component starting with schema:, instance:, node:), so a v0.2 cached source with an explicit cache_path is found by the sibling check only.

Finding outside this issue (not fixed)

PostgreSQL truncates identifiers to 63 bytes, and Orcapod's table names for function tables are much longer. Whether such tables work at all, and what truncation does to the layout suffix, was not verified (no server here).

Test plan

  • uv run pytest tests/ on Python 3.12: 7866 passed, 97 skipped, 18 xfailed
  • uv run pytest test-objective/ passes
  • New test files on Python 3.11 and 3.13
  • Golden hash tests pass unchanged
  • uv run --with ruff ruff check ., ruff format --check .
  • uv run --with basedpyright basedpyright: exit 0
  • MinIO test: CI only

🤖 Generated with Claude Code

Edgar Y. Walker and others added 30 commits November 11, 2026 15:31
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….2 (ITL-910)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….2 (ITL-910)

Bump starfix to >=0.5.0,<0.6 and the Arrow hasher label to arrow_v0.2. Hash
pyarrow's canonical extension types and extension-typed schemas with their
extension identity instead of as their storage type.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…row_v0.2 (ITL-910)

Explicitly approved regeneration (developer decision 3, November 11, 2026):
184 Arrow-derived values change (arrow 53/53, datagram 40/171, pipeline
68/305, schema 22/92, semantic 1/64); no key added or removed among them.
21 arrow entries added: fixed-size lists, the ITL-848 collision pairs, a
chunked Boolean column, canonical extension types and extension schemas.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (ITL-910)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nce and DESIGN_ISSUES (ITL-910, WIP)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ash label fail explicitly (ITL-910)

Adds orcapod.errors.StoreHashLabelError.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (ITL-910)

A v0.3 node whose pipeline, result, operator, cached-source or side-effect
table holds rows keyed under arrow_v0.1 (Orcapod v0.2, starfix format 1) now
raises StoreHashLabelError on read and before its first write, and
PipelineJob.run checks every node before the first one runs, so a refused
store is left exactly as it was. No opt-out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…loaded jobs; tests (ITL-910)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ect the ITL-888 reuse claim (ITL-910)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s (ITL-910)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…refusing the store (ITL-910)

Developer decision of November 11, 2026 (ITL-938 session): v0.3 writes and uses
arrow_v0.2 rows in the same tables next to arrow_v0.1 rows. Remove
StoreHashLabelError, every check_stored_hash_labels() and the PipelineJob.run
pre-flight. Every whole-table read keeps rows of the current label only
(keep_rows_hashed_under); stored_hash_labels() lists the labels a table holds.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… them (ITL-910)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…nder another label fail (ITL-910)

Developer decisions of November 11, 2026: a read that leaves out rows of another
hash label logs one warning with the total; a side-effect node whose invocation
log holds deliveries logged under another Arrow label raises
SideEffectLogHashLabelError before delivering anything.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…reported, kept)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…eck (ITL-944)

Add the manifest v1.json (key std:v1:default) and make it the default data
context. released_manifests.json pins the sha256 of every released manifest;
v1 stays open (null) until the release-preparation commit sets its digest.
The manifest schema accepts v<int> as well as v<int>.<int>.

The content hash of a stream without a producer covers its _context_key
column, so three golden entries (schema:source_stream_builder.*.content_hash)
and the stream hashes pinned in test_struct_layout_identity move with the key.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…d-layout report (ITL-944)

Work in progress: existing tests that name the old paths, columns and
ResultCache signature are not updated yet.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ITL-944)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ld layouts reported (ITL-944)

Every stored row names the data context that wrote it (__data_context):
function pipeline and result tables, operator-cache tables, cached-source
tables and side-effect logs. It replaces __input_data_context_key and the
result table's _context_key. Layouts move to pdb_v2, rdb_v2, tdb_v2, and
operator-cache and cached-source tables gain odb_v1 and sdb_v1.

Reads and lookups keep rows of the current data context only. A table at an
older layout is counted and reported, never read as current, never written;
a side-effect log at an older layout, or holding deliveries of another data
context, raises SideEffectLogDataContextError before any delivery.

The result table also stores the full function version
(__pf_var_function_version). The label-based row filtering of PR #309
(hashing/stored_hash_labels.py) is removed; orcapod.contexts.stored_data_contexts
lists the data contexts a table holds.

Golden: pipeline:job.table_paths and pipeline:polars_filter_expr_job.table_paths
change (layout component only), and the four table[...] entry names under each
job follow the new paths with unchanged values.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…es move to an unfrozen registration (ITL-944)

The v1 manifest gains released_in, previous, definitions, libraries, golden
and changes (ITL-938 design document, section 7.4). The registered logical
types and the value handlers of their Python values move from the manifest to
contexts/logical_types.json, which is not frozen; a manifest whose type
converter refers to logical_type_registry takes both from that file. What the
default context registers is unchanged (pinned by a test).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…n older store (ITL-944)

A function pod with ctx_arg performs an external action, and its completions
are its function tables. On a store written by an earlier version, or holding
completions of another data context, it would deliver every effect again
without an error. It now raises SideEffectLogDataContextError, naming the
tables, before anything is delivered, like a side-effect pod does for its log.

Whether a node reports and skips stored rows of other generations or fails is
decided in one place, contexts/stored.account_for_stale_tables. The error
carries record_paths (every table found).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… machinery (ITL-944)

std:v0.1:default no longer resolves: the error names it as the data context
of Orcapod before v0.3, whose manifest is to live in orcapod-sanctuary. A
node saved under it loads under the current data context with a warning.

Removed: SchemaVersionError, NodeConfig(ignore_schema=...), orcapod.migrations
and the 'orcapod migrate' command. A table at a path without a layout
component (Orcapod v0.1) is counted like any other old layout.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A node, cache or cached source that would store a row for an input whose data
context differs from its own raises InputValidationError naming both keys,
before anything is computed, delivered or written. For a function node the
whole input is checked outside the row error policy. The eventual behaviour
(the node's data context wins) is ITL-951.

Also records the developer's answers and the outcome in the plan, and moves
the pre-v1 data context constants to system_constants to avoid an import cycle.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Edgar Y. Walker and others added 7 commits November 11, 2026 20:38
- attach_databases resets the stale-table check of function and operator
  nodes, so a newly attached store is checked again.
- ResultCache.store refuses an output of another data context, and a
  caller's additional_constraints cannot replace the data context filter
  of ResultCache.lookup.
- Streams rebuilt from stored rows (operator cache, cached source) get the
  node's data context instead of the default one.
- resolve_context raises for a full key that is not its manifest's key.
- The open-manifest gate also skips pre-releases.
- The manifest schema's example is a v1 context; CHANGELOG and docs say the
  other-context refusal is not reached inside a PipelineJob.
- test-objective: the two tests of the removed v0.1 context use v1.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…x (ITL-954)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… with moved hashes (ITL-954)

Failing before the fix: with moved hashes the side-effecting nodes deliver again.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…tever their hashes (ITL-954)

Side-effecting nodes of both kinds raise before delivering; other function
tables are reported; a job run reports one total of the remaining tables.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…-954)

Hashing reference, function pods page, CHANGELOG, agent instructions, DESIGN_ISSUES DC2.
The fixture is regenerated from the final pods module.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… (ITL-954)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
ITL-954 Find tables written before v0.3 by scanning the store under a node's stable path prefix, so side-effecting nodes fail and old tables are reported

Overview

The developer decided (ITL-938, November 11, 2026) that v0.3 counts and reports tables written by an earlier version, and that a side-effecting node (a SideEffectPod, or a function pod that takes the invocation context) fails explicitly on an older store rather than deliver again.

ITL-944 implements this by looking at the node's own path with the older layout suffix. That stops working once the v0.3 hash changes are combined: the label rule (ITL-945) and the other changes move every pipeline hash and function URI, so a v0.2 table is at a path v0.3 never computes. The report would then find nothing, and every side effect would be delivered again on the first v0.3 run against a v0.2 store. Found by the ITL-945 worker; confirmed by the ITL-944 worker's analysis of the real v0.2.0 store fixture.

What is stable across versions (measured on the v0.2.0 fixture): the path prefix <job>/<function name>/ and <job>/_result/<function name>/; for a context-taking pod <job>/side_effect_function/<name>/; for a SideEffectPod <job>/side_effects/<pod name>/. Operator caches and default cached sources have no usable name.

Goals & Success Criteria

  • A way to list the tables that exist under a path prefix: one method on ArrowDatabaseProtocol, implemented for the in-memory and Delta stores, the extension-aware wrapper and the no-op store, and for the connector stores (SQLite, PostgreSQL, Spiral) as far as their table naming allows.
  • Old versus current is decided by layout, not by hash: under the prefix, a table whose last component is the current layout of its kind is current; anything else was written before v0.3.
  • Side-effecting nodes of both kinds: any pre-v0.3 table under the node's prefix raises the explicit error before anything is delivered. The error names the tables.
  • Ordinary tables: counted and reported, with one store-level total at job start covering operator caches and cached sources.
  • The behaviour when a store cannot list its tables is the developer's decision.
  • Tests against real v0.2.0 bytes: a new store fixture, generated with Orcapod v0.2.0, that includes a sink and a context-taking pod. The existing fixture is not modified.
  • The sibling-path check stays as well; it is exact where hashes did not move.

Dependencies & Risks

Resources & References

Review in Linear

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3727730-0ea9-4519-a870-9dd4fd8f29b9
Commits

Reviewing files that changed from the base of the PR and between d61e3e3 and 8b291c9.

Files ignored due to path filters: 2

  • tests/test_arrays/data/v02_full_store.tar.gz is excluded by !**/*.gz
  • uv.lock is excluded by !**/*.lock
Files selected for processing: 93

  • .zed/rules
  • CHANGELOG.md
  • CLAUDE.md
  • DESIGN_ISSUES.md
  • changelog.d/ITL-954.md
  • docs/concepts/arrays.md
  • docs/concepts/function-pods.md
  • docs/reference/hashing.md
  • pyproject.toml
  • src/orcapod/cli/__init__.py
  • src/orcapod/cli/migrate.py
  • src/orcapod/contexts/__init__.py
  • src/orcapod/contexts/core.py
  • src/orcapod/contexts/data/schemas/context_schema.json
  • src/orcapod/contexts/data/v0.1.json
  • src/orcapod/contexts/data/v1.json
  • src/orcapod/contexts/logical_types.json
  • src/orcapod/contexts/registry.py
  • src/orcapod/contexts/released_manifests.json
  • src/orcapod/contexts/stored.py
  • src/orcapod/core/cached_function_pod.py
  • src/orcapod/core/data_function.py
  • src/orcapod/core/nodes/function_node.py
  • src/orcapod/core/nodes/operator_node.py
  • src/orcapod/core/result_cache.py
  • src/orcapod/core/sources/cached_source.py
  • src/orcapod/databases/connector_arrow_database.py
  • src/orcapod/databases/delta_lake_databases.py
  • src/orcapod/databases/extension_aware_database.py
  • src/orcapod/databases/in_memory_databases.py
  • src/orcapod/databases/noop_database.py
  • src/orcapod/errors.py
  • src/orcapod/hashing/arrow_hashers.py
  • src/orcapod/hashing/schema_cleaner.py
  • src/orcapod/hashing/versioned_hashers.py
  • src/orcapod/logical_types/__init__.py
  • src/orcapod/logical_types/builtin_logical_types.py
  • src/orcapod/migrations/__init__.py
  • src/orcapod/migrations/pipeline_db.py
  • src/orcapod/migrations/result_db.py
  • src/orcapod/migrations/types.py
  • src/orcapod/pipeline/graph.py
  • src/orcapod/pipeline/job.py
  • src/orcapod/protocols/database_protocols.py
  • src/orcapod/side_effects.py
  • src/orcapod/system_constants.py
  • src/orcapod/types.py
  • superpowers/plans/2026-11-11-itl-910-adopt-starfix-05.md
  • superpowers/plans/2026-11-11-itl-910-followup-ignore-old-label-rows.md
  • superpowers/plans/2026-11-11-itl-944-data-context-v1.md
  • superpowers/plans/2026-11-11-itl-954-prefix-scan.md
  • test-objective/unit/test_contexts.py
  • tests/test_arrays/data/make_v02_full_store.py
  • tests/test_arrays/test_array_v02_store.py
  • tests/test_arrays/v02_full_store_pods.py
  • tests/test_cli/test_migrate.py
  • tests/test_contexts/__init__.py
  • tests/test_contexts/test_data_context_v1.py
  • tests/test_core/data_function/test_data_function.py
  • tests/test_core/operators/test_async_sync_equivalence.py
  • tests/test_core/operators/test_group_by.py
  • tests/test_core/operators/test_join_meta_columns.py
  • tests/test_core/operators/test_materialize_source_info.py
  • tests/test_core/operators/test_operator_node.py
  • tests/test_core/operators/test_operator_node_non_active.py
  • tests/test_core/side_effect_pod/test_side_effect_pod.py
  • tests/test_core/sources/test_cached_source.py
  • tests/test_core/test_caching_integration.py
  • tests/test_core/test_result_cache.py
  • tests/test_core/test_table_scope.py
  • tests/test_databases/test_list_table_paths.py
  • tests/test_hashing/golden/cases.py
  • tests/test_hashing/golden/data/arrow.json
  • tests/test_hashing/golden/data/datagram.json
  • tests/test_hashing/golden/data/pipeline.json
  • tests/test_hashing/golden/data/schema.json
  • tests/test_hashing/golden/data/semantic.json
  • tests/test_hashing/golden/generate_golden_hashes.py
  • tests/test_hashing/test_hash_cachers.py
  • tests/test_hashing/test_pandas_handlers.py
  • tests/test_hashing/test_starfix_arrow_hasher.py
  • tests/test_hashing/test_starfix_format2.py
  • tests/test_logical_types/test_roundtrips.py
  • tests/test_migrations/test_migration_types.py
  • tests/test_migrations/test_pipeline_db.py
  • tests/test_migrations/test_result_db.py
  • tests/test_pipeline/test_node_descriptors.py
  • tests/test_pipeline/test_pre_v03_tables.py
  • tests/test_pipeline/test_serialization_helpers.py
  • tests/test_pipeline/test_store_write_failure.py
  • tests/test_pipeline/test_stored_data_context.py
  • tests/test_semantic_types/test_struct_layout_identity.py
  • tests/test_types.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@eywalker

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Posted by a Claude Code agent on behalf of @eywalker.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

eywalker pushed a commit that referenced this pull request Nov 12, 2026
…ce ids, native containers, pre-v0.3 table scan, GroupBy tags

Bring the design document in line with the developer's decisions of November 11, 2026
made after the design session, and with PRs #313 to #318:

- finding E (MergeJoin) withdrawn; ITL-942 described as in PR #315 (7 golden entries
  changed, 32 added, none removed); L2 is ITL-953
- a default source id built from a hash is <source kind>:<algorithm label>:<hex>, the
  stated exception to bare hashes inside names (rule 5a)
- native list/set container logical types carry no version of their own
- tables written before v0.3 are found by a prefix scan (list_table_paths, ITL-954);
  a store that cannot list warns once per node and proceeds
- GroupBy keeps non-key tags as tags (ITL-955); tags as data via a derived source (ITL-939)
- issue and PR numbers in the cut list and Part 8

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@eywalker

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Posted by a Claude Code agent on behalf of @eywalker.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…961)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@eywalker

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Posted by a Claude Code agent on behalf of @eywalker.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eywalker

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Posted by a Claude Code agent on behalf of @eywalker.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

eywalker pushed a commit that referenced this pull request Nov 12, 2026
…tten-before-v03-by-scanning' (#318, ITL-954) into ITL-967

Conflicts, all additions on both sides against main's ITL-919 changes, both
kept: cached_function_pod.py (set_auto_flush and
stale_result_tables_accounted_for), delta_lake_databases.py imports, job.py
imports.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@eywalker eywalker mentioned this pull request Nov 12, 2026
7 tasks done
@eywalker

Copy link
Copy Markdown
Contributor Author

Closing as superseded: this branch's head is an ancestor of #324's merged head (6dc2a51), and #324 is merged to main as e140862. The findings CodeRabbit raised on this code were handled in #324's review rounds; the few that remain are tracked in ITL-975, ITL-951 and ITL-904.

Posted by a Claude Code agent on behalf of @eywalker.

@eywalker eywalker closed this Nov 12, 2026
@eywalker
eywalker deleted the eywalker/itl-954-find-tables-written-before-v03-by-scanning branch November 17, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant