Repository navigation
fix(databases): a Delta table that cannot be read raises StoreReadError, never no rows (ITL-884) #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eywalker
merged 26 commits into
main
from
eywalker/itl-884-delta-read-failures-are-returned-as-no-rows
Nov 11, 2026
Merged
fix(databases): a Delta table that cannot be read raises StoreReadError, never no rows (ITL-884) #290
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b2a3a69
test(databases): failing regression tests for Delta read failures rep…
79141a5
fix(databases): a Delta table that cannot be read raises StoreReadErr…
c7ffc7d
docs: state the Delta read-failure and append type-check contract (IT…
e29890d
Merge remote-tracking branch 'origin/main' into eywalker/itl-884-delt…
9a1ae63
Merge remote-tracking branch 'origin/main' into eywalker/itl-884-delt…
5a06764
fix(databases): flush raises StoreReadError and the append refusal as…
3c75c09
fix(pipeline): raise StoreReadError on its own when another node also…
ce32c9e
refactor(pipeline): give the async store-error selection #287's shape…
3785d71
docs(plans): name the async helper as implemented (ITL-884)
7d96a01
docs(plans): fix the remaining helper name in the plan's code sample …
486db1d
docs(tests): docstrings for the store-read-failure tests (ITL-884)
7123a20
Merge remote-tracking branch 'origin/main' into eywalker/itl-884-delt…
d32c84d
style(errors): unquote a local annotation ruff UP037 flags (ITL-884)
b4387c0
Merge remote-tracking branch 'origin/main' into eywalker/itl-884-delt…
65c2bd9
docs(plans): resume notes after merging main (ITL-884)
f6a3c3a
docs(errors): StoreReadError no longer claims nothing was recomputed …
0369cfc
refactor(databases): callers wrap store errors; no message-only param…
b55a3e6
fix(databases): the append check accepts new nested struct fields (IT…
488e2a2
docs(agents): add the no message-only parameters rule (ITL-884)
8f282b8
Merge origin/main (ITL-878 #287) into ITL-884: one path for store rea…
4f0b4f1
Merge origin/main (ITL-821 #296) into ITL-884
65c6330
fix(pipeline): name node and row on async pipeline-record store error…
cf029bb
Merge origin/main (ITL-875 #297) into ITL-884
ffe4448
fix(databases): the append check compares the types the Delta writer …
51dc905
fix(databases): null-typed values append to a typed Delta column (ITL…
11efe63
fix(databases): a null struct field inside a list no longer hides its…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: metamorphic-labs/orcapod-python
Length of output: 5883
Script executed:
Repository: metamorphic-labs/orcapod-python
Length of output: 24027
Script executed:
Repository: metamorphic-labs/orcapod-python
Length of output: 27115
Script executed:
Repository: metamorphic-labs/orcapod-python
Length of output: 15832
Script executed:
Repository: metamorphic-labs/orcapod-python
Length of output: 10918
Script executed:
Repository: metamorphic-labs/orcapod-python
Length of output: 6427
Preserve store failures inside exception groups before skipping a row.
A fail-loud post-run hook can raise an
ExceptionGroupcontaining aStoreError.process_onecatches the group as a generic exception and skips the row, so the run can succeed without its output.Inspect groups with
StoreError.in_group(), attach row context to their store-error leaves, and propagate them before the skip branch. Apply the same rule toFunctionJobNode.execute(), where a data function can raise such a group anderror_policy="continue"skips the row.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid, but pre-existing and out of scope for this PR: the same holds for
StoreWriteErroronmain(#287). A hook or data function that raises anExceptionGroupcontaining a store error is treated as a row failure. Tracked in ITL-918 (https://linear.app/metamorphic/issue/ITL-918).Posted by a Claude Code agent on behalf of @eywalker.