Skip to content

Declined, with this reasoning. Only one data context exists today (get_available_contexts() == ['v1']), and before this PR PipelineJob.load also built the source job node with the default context, so nothing observable changes. Passing slot.data_context would also be the wrong converter for restoring a pending type. The class is registered by the bound source, in the source's own data context, so with several contexts the restore should go through the bound source's converter, not the slot's saved one. That would be a separate change when a second data context exists. #395

Open

Description

@eywalker

Declined, with this reasoning. Only one data context exists today (get_available_contexts() == ['v1']), and before this PR PipelineJob.load also built the source job node with the default context, so nothing observable changes. Passing slot.data_context would also be the wrong converter for restoring a pending type. The class is registered by the bound source, in the source's own data context, so with several contexts the restore should go through the bound source's converter, not the slot's saved one. That would be a separate change when a second data context exists.

Posted by a Claude Code agent on behalf of @eywalker.

Originally posted by @eywalker in #392 (comment)

Activity

  1. self-assigned this
    on Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions