Add DISCID_USE_HTTPS build flag to build with https URL support#71
Open
phw wants to merge 1 commit into
Open
Conversation
Only if DISCID_USE_HTTPS is set discid_get_submission_url and discid_get_webservice_url will return URLs with https.
Member
Author
|
@Rigo-V I would appreciate if you could look over my changes here. I'd like to migrate over to have HTTPS being used as default, but also limit the impact. Once we have this in a release we can encourage people to build and test with this feature enabled. I'll definitely update the builds we do for MusicBrainz Picard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the use of HTTPS in generated URLs, as added in #68, a build-time option.
Only if DISCID_USE_HTTPS is set discid_get_submission_url and discid_get_webservice_url will return URLs with https instead of http.
The default for now is disabled. To enable, run cmake with
-DENABLE_USE_HTTPS=ONor in case of autotools run configure with--enable-use-https=yes. See also the details added toINSTALL.We should make this enabled by default in a later release.