Skip to content

Handle nil values appropriately in approximately-equal#43

Merged
galdre merged 1 commit into
mainfrom
galdre/approximately-equal-nil
Sep 2, 2025
Merged

Handle nil values appropriately in approximately-equal#43
galdre merged 1 commit into
mainfrom
galdre/approximately-equal-nil

Conversation

@galdre

@galdre galdre commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

It's nice to be able to assert empty? on a coll that could be nil. It also seems we should be able to assert nil? on nil. Seemed like a bug!

(deftest failing-test
  (is (=? empty? nil)))
  
(deftest still-failing-test
  (is (=? nil? nil)))

The issue is that (= nil (type nil)).

@galdre galdre requested a review from camsaul as a code owner September 2, 2025 16:43
@galdre galdre merged commit bf37881 into main Sep 2, 2025
2 checks passed
@galdre galdre deleted the galdre/approximately-equal-nil branch September 2, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants