Skip to content

[pulse][java] fix a stale line number in the compared-to-null expectation - #2315

Merged
dulmarod merged 1 commit into
meta:mainfrom
VladimirMakaev:java-pulse-compared-to-null-line
Nov 20, 2026
Merged

dulmarod merged 1 commit into
meta:mainfrom
VladimirMakaev:java-pulse-compared-to-null-line

Conversation

@VladimirMakaev

@VladimirMakaev VladimirMakaev commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Fixes main's failing direct_java_pulse_test: issues.exp kept a stale line number (831, now 863) after #2169 merged.

The two derefAfterComparisonToNullBad rows added in #2169 cite was compared to null on line 831, but in NullPointerExceptions.java the comparison is on line 863 and line 831 is blank.
The expectation was written against an earlier layout of that file, so direct_java_pulse_test
fails on main.

Only the cited line number changes; the two rows are otherwise identical.

Test plan

make direct_java_pulse_test fails on main and passes with this change. The expectation is
regenerated with make direct_java_pulse_replace, not edited by hand.

…tion

The two `derefAfterComparisonToNullBad` rows added in meta#2169 cite `was compared to null on line
831`, but in `NullPointerExceptions.java` the comparison is on line 863 and line 831 is blank.
The expectation was written against an earlier layout of that file, so `direct_java_pulse_test`
fails on main.

Only the cited line number changes; the two rows are otherwise identical.

## Test plan
`make direct_java_pulse_test` fails on main and passes with this change. The expectation is
regenerated with `make direct_java_pulse_replace`, not edited by hand.
@meta-cla meta-cla Bot added the CLA Signed label Nov 20, 2026
@dulmarod
dulmarod merged commit 2ebceff into meta:main Nov 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants