Repository navigation
[pulse][java] fix a stale line number in the compared-to-null expectation - #2315
Merged
dulmarod merged 1 commit intoNov 20, 2026
Merged
Conversation
…tion The two `derefAfterComparisonToNullBad` rows added in meta#2169 cite `was compared to null on line 831`, but in `NullPointerExceptions.java` the comparison is on line 863 and line 831 is blank. The expectation was written against an earlier layout of that file, so `direct_java_pulse_test` fails on main. Only the cited line number changes; the two rows are otherwise identical. ## Test plan `make direct_java_pulse_test` fails on main and passes with this change. The expectation is regenerated with `make direct_java_pulse_replace`, not edited by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes main's failing direct_java_pulse_test: issues.exp kept a stale line number (831, now 863) after #2169 merged.
The two
derefAfterComparisonToNullBadrows added in #2169 citewas compared to null on line 831, but inNullPointerExceptions.javathe comparison is on line 863 and line 831 is blank.The expectation was written against an earlier layout of that file, so
direct_java_pulse_testfails on main.
Only the cited line number changes; the two rows are otherwise identical.
Test plan
make direct_java_pulse_testfails on main and passes with this change. The expectation isregenerated with
make direct_java_pulse_replace, not edited by hand.