Skip to content

[java] Model zip stream entry methods for Pulse - #2310

Merged
dulmarod merged 1 commit into
meta:mainfrom
tanvir-ux:fix/zip-stream-entry-models
Nov 18, 2026
Merged

dulmarod merged 1 commit into
meta:mainfrom
tanvir-ux:fix/zip-stream-entry-models

Conversation

@tanvir-ux

Copy link
Copy Markdown
Contributor

ZipInputStream.getNextEntry and JarInputStream.getNextJarEntry return null when there are no more entries and may throw IOException. ZipOutputStream.putNextEntry and closeEntry do not close the stream. Left unknown, Pulse missed the null dereference and dropped the stream, so a stream that was not closed after those calls was not reported.

Please see CONTRIBUTING.md for how to set up your development environment and run tests.

ZipInputStream.getNextEntry and JarInputStream.getNextJarEntry return
null when there are no more entries and may throw IOException.
ZipOutputStream.putNextEntry and closeEntry do not close the stream.
Left unknown, Pulse missed the null dereference and dropped the stream,
so a stream that was not closed after those calls was not reported.

Co-authored-by: Tanvir Alam <tanviralamshuvo@gmail.com>
@meta-cla meta-cla Bot added the CLA Signed label Nov 18, 2026
@dulmarod
dulmarod merged commit da50a08 into meta:main Nov 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants