Repository navigation
[pulse] record disjuncts skipped by the balanced disjunct strategy as dropped - #2168
Open
VladimirMakaev wants to merge 1 commit into
Open
VladimirMakaev wants to merge 1 commit into
VladimirMakaev wants to merge 1 commit into
Conversation
VladimirMakaev
force-pushed
the
pulse-balanced-disjunct-accounting
branch
from
October 3, 2026 19:53
79bac0e to
6bd2545
Compare
VladimirMakaev
marked this pull request as ready for review
October 5, 2026 15:27
VladimirMakaev
added a commit
to VladimirMakaev/infer
that referenced
this pull request
Oct 5, 2026
… dropped With `--pulse-balanced-disjuncts-strategy`, pre disjuncts left without budget at a node (more of them than room in its post) still ran the node's first instruction with a limit of 0, then vanished: they were neither counted as dropped nor joined into the over-approximate state. This loses, e.g., transitive accesses at loop heads, and every report with `--pulse-max-disjuncts 0 --pulse-over-approximate-reasoning`: Upstream-PR: meta#2168 PR-Head: 6bd2545 PR-Base: 9cc2641
Contributor
|
@jvillard could you take a look? |
VladimirMakaev
force-pushed
the
pulse-balanced-disjunct-accounting
branch
from
October 7, 2026 15:55
6bd2545 to
70141b9
Compare
Contributor
|
I don't think this strategy is used anywhere, looks like an old experiment to me. @davidpichardie any idea? Should the balanced strategy be removed, kept as-is, or should this PR be merged? |
… dropped
With `--pulse-balanced-disjuncts-strategy`, pre disjuncts left without budget at a node (more of
them than room in its post) still ran the node's first instruction with a limit of 0, then
vanished: they were neither counted as dropped nor joined into the over-approximate state. This
loses, e.g., transitive accesses at loop heads, and every report with `--pulse-max-disjuncts 0
--pulse-over-approximate-reasoning`:
```c
// infer --pulse-balanced-disjuncts-strategy --pulse-max-disjuncts 0
// --pulse-over-approximate-reasoning
int uninit_one_branch_bad(int b) {
int x;
if (b) {
x = 42;
}
return x; // Infer missed: uninitialized value
}
```
They are now skipped without being executed and recorded as dropped, as the default strategy
(unchanged) does once the post is full, which is exactly when a balanced disjunct gets no budget.
The `pulse_disjuncts_dropped` stat now counts them.
## Test plan
New `c/pulse-over-only-balanced` runs the `c/pulse-over-only` tests with the balanced strategy and
expects the same issues (none before). `build_systems/disjunctive_domain`: balanced `loop` records
7 (was 5) and 10 (was 6) dropped disjuncts. All codetoanalyze tests pass.
VladimirMakaev
force-pushed
the
pulse-balanced-disjunct-accounting
branch
from
November 20, 2026 16:29
70141b9 to
4159413
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--pulse-balanced-disjuncts-strategy, pre disjuncts left without budget at a node (more ofthem than room in its post) still ran the node's first instruction with a limit of 0, then
vanished: they were neither counted as dropped nor joined into the over-approximate state. This
loses, e.g., transitive accesses at loop heads, and every report with
--pulse-max-disjuncts 0 --pulse-over-approximate-reasoning:They are now skipped without being executed and recorded as dropped, as the default strategy
(unchanged) does once the post is full, which is exactly when a balanced disjunct gets no budget.
The
pulse_disjuncts_droppedstat now counts them.Test plan
New
c/pulse-over-only-balancedruns thec/pulse-over-onlytests with the balanced strategy andexpects the same issues (none before).
build_systems/disjunctive_domain: balancedlooprecords7 (was 5) and 10 (was 6) dropped disjuncts. All codetoanalyze tests pass.