Skip to content

fix(core): docusaurus serve serves existing .html files as-is (AI-assisted) #12904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 15 commits into from
Nov 6, 2026
Merged

fix(core): docusaurus serve serves existing .html files as-is (AI-assisted) #12904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bece1ce
fix(core): docusaurus serve adds a trailing slash to pages with a dot…
slorber Nov 6, 2026
018b611
fix(core): docusaurus serve does all the redirects, keeping the query…
slorber Nov 6, 2026
57f93ed
fix(core): docusaurus serve keeps the baseUrl with encoded slashes (A…
slorber Nov 6, 2026
e84dd30
test(core): cover the isPage() guards of docusaurus serve (AI-assisted)
slorber Nov 6, 2026
eb538a9
Merge the isPage() tests (AI-assisted)
slorber Nov 6, 2026
7083089
Merge the isPage() tests (AI-assisted)
slorber Nov 6, 2026
849a8e7
Merge main into the all redirects fix (AI-assisted)
slorber Nov 6, 2026
69ea7b6
Merge main into the encoded slashes fix (AI-assisted)
slorber Nov 6, 2026
7204859
fix(core): `docusaurus serve` serves existing .html files as-is (AI-a…
slorber Nov 6, 2026
09dd3a0
test(core): capture that missing .html files keep the query string in…
slorber Nov 6, 2026
ce19b9e
Merge main into the all redirects fix
slorber Nov 6, 2026
2bf011f
Merge the all redirects fix into the encoded slashes fix
slorber Nov 6, 2026
6fc2f31
Merge the encoded slashes fix into the existing .html files fix
slorber Nov 6, 2026
42b1bd7
Merge main into the existing .html files fix
slorber Nov 6, 2026
e0dc1a0
fix(core): resolve existing .html files like serve-handler does
slorber Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions argos/tests/screenshot.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@
'/tests/blog/archive',
'/tests/pages/code-block-tests',
'/tests/pages/embeds',
// Flaky because of hydration error with docusaurus serve + .html
'/tests/blog/x/y/z.html',
'/tests/docs/dummy.html',
// Cause weird docusaurus serve errors:
'/tests/docs/tests/ascii/%C3%A6%C3%B8%C3%A5',
'/tests/docs/tests/ascii/folder/%C3%A6%C3%B8%C3%A5',
Expand All @@ -69,7 +66,7 @@
// changelog docs
pathname.startsWith('/changelog') ||
// versioned docs
pathname.match(/^\/docs\/((\d\.\d\.\d)|(next))\//) ||

Check warning on line 69 in argos/tests/screenshot.spec.ts

View workflow job for this annotation

GitHub Actions / Lint AutoFix 

Capture group '(next)' should be converted to a named or non-capturing group

Check warning on line 69 in argos/tests/screenshot.spec.ts

View workflow job for this annotation

GitHub Actions / Lint AutoFix 

Capture group '(\d\.\d\.\d)' should be converted to a named or non-capturing group

Check warning on line 69 in argos/tests/screenshot.spec.ts

View workflow job for this annotation

GitHub Actions / Lint AutoFix 

Capture group '((\d\.\d\.\d)|(next))' should be converted to a named or non-capturing group
// verbose useless dogfooding pages
pathname.startsWith('/tests/docs/toc/') ||
pathname.startsWith('/tests/docs/tags/') ||
Expand Down Expand Up @@ -106,8 +103,8 @@
return str.startsWith('/') ? str.slice(1) : str;
}

pathname = removeTrailingSlash(pathname);

Check warning on line 106 in argos/tests/screenshot.spec.ts

View workflow job for this annotation

GitHub Actions / Lint AutoFix 

Assignment to function parameter 'pathname'
pathname = removeLeadingSlash(pathname);

Check warning on line 107 in argos/tests/screenshot.spec.ts

View workflow job for this annotation

GitHub Actions / Lint AutoFix 

Assignment to function parameter 'pathname'

if (pathname === '') {
return 'index';
Expand Down
1 change: 1 addition & 0 deletions packages/docusaurus/src/commands/serve/__tests__/__fixtures__/build/legacy.html/index.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading