Repository navigation
Conversation
stopWorkers() stops every background worker except the pool optimizer. shutDown() relies on it before saving the cache state, so with the pool optimizer enabled the optimizer thread can still resize pools while the state is being serialized; the destructor has the same window until the PoolOptimizer member itself is destroyed. Test: a counting PoolOptimizeStrategy is no longer called after stopWorkers() returns.
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@AlnisM has imported this pull request. If you are a Meta employee, you can view this in D131236874. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
stopWorkers()stopped every background worker except the pool optimizer, so the optimizer could still resize pools whileshutDown()was serializing the cache. NowstopWorkers()stops it too.Test Plan:
SimplePoolOptimizationTest.StopWorkersStopsPoolOptimizerwaits for the optimizer to run, callsstopWorkers()and checks that the strategy is not called again; it fails without the fix.