Update ham regions, split by ITU#922
Draft
vidplace7 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Meshtastic Config.LoRaConfig.RegionCode to stop combining ITU regions 2 and 3 for ham bands, enabling different per-region defaults (e.g., slotOverrides/frequencies) going forward.
Changes:
- Renames the combined ITU2/3 2m region code to an ITU2-specific code.
- Splits the combined ITU2/3 70cm region code into distinct ITU2 and ITU3 values.
- Adds an explicit ITU3 2m region code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+970
to
+974
| * ITU Region 2 Amateur Radio 70cm band (420-450 MHz) | ||
| * Note: Some countries do not allocate 420-430 Mhz or 440-450 MHz. | ||
| * Check local law! | ||
| */ | ||
| ITU2_70CM = 34; |
Member
Author
There was a problem hiding this comment.
These regions are not actually being consumed outside of PRs in meshtastic/firmware.
This should be a safe change?
Stop combining ITU 2 and 3. They will need VERY different default slotOverrides (default freq). In effect, this means each ham band we support will need 3 "regions", ITU1, ITU2, ITU3. This will allow us to better support hams around the world without stirring anger.
Member
Author
|
Marking as DRAFT until #923 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT: #923 should be merged (and cherrypicked to
develop) first 🙏 so we don't end up in conflict-hell here.NOTE: This PR includes renames! (Normally breaking, but nothing relies upon these protos yet afaik)
Stop combining ITU 2 and 3. They will need VERY different default slotOverrides (default freq).
In effect, this means each ham band we support will need 3 "regions", ITU1, ITU2, ITU3.
This will allow us to better support hams around the world (hopefully) without stirring anger.