feat(sim): add Batumi radio physics for DCR#64
Conversation
a5f20d9 to
a29a2b5
Compare
|
I'm not a maintainer of this repo and don't claim or intend to be, but respectfully this is a colossal PR (11k lines added with many new files & features) for a repo with, as far as I've seen, a single maintainer who isn't maintaining this repo as their day job. IMO this would need to at minimum be split into separate digestible PRs with clear intention behind the changes to be accepted, but that's not my call. I'll not go on an anti-AI rant for now. |
|
I agree with the above; while I think there might be useful additions in the PR, it is currently way too big to be reviewed. Besides that, I would like to keep the main branch clean by only simulating what current Meshtastic devices do or can be configured to. Dynamic Coding Rate is not yet there (there is this open PR though: meshtastic/firmware#10359), so I would propose to keep those on your fork, at least for now. |
|
Thanks @GUVWAF @zandi. I mainly did this to check my hypotheses on meshtastic/firmware#10359 and dynamic power, so I don't offer to main branch something that won't work in practice. DCR seems a win and dynamic power seems a fail. That part is done for me, but I'll be happy to spend some AI tokens to document and clean it up make it useful for future experimenters. Will fix any comments there. I hope it's not too annoying with the AI-side - without AI in this case I'll still be dreaming to make dynamic power work, here now I have model that it's not a helpful thing on our real mesh. I do not have intention to make your life harder as maintainer, just sharing results that I happen to have. |
4791081 to
73e0189
Compare
After rebasing the radio-policy stack onto current master, the capture/RF model changes produce a new deterministic ten-node baseline. Keep the regression test strict, but update the expected counters to the current modeled behavior.
73e0189 to
ec91e5e
Compare
Summary
This draft remains the rollup/reference branch for the Meshtasticator radio-physics and policy work split from the original large patch. Please review the smaller draft PRs below in order; each slice has its own focused commit, docs/tests, and validation notes.
The stack keeps default simulator behavior unchanged unless the new CLI flags or packaged preset are used. The main goal is to make DCR/DTP experiments measurable in Meshtasticator without asking reviewers to swallow one giant patch at once.
Split Tracker
Review Notes
Validation
The split PRs carry focused validation for their own files. The final cleanup slice was checked with focused tests, ruff, compileall, a static/DCR/DCR+DTP smoke comparison, full unittest, diff whitespace checks, and a private-marker scan.