Skip to content

feat(sim): add Batumi radio physics for DCR#64

Closed
Komzpa wants to merge 9 commits into
meshtastic:masterfrom
Komzpa:codex/batumi-radio-physics
Closed

feat(sim): add Batumi radio physics for DCR#64
Komzpa wants to merge 9 commits into
meshtastic:masterfrom
Komzpa:codex/batumi-radio-physics

Conversation

@Komzpa
Copy link
Copy Markdown
Contributor

@Komzpa Komzpa commented Apr 29, 2026

Summary

This draft remains the rollup/reference branch for the Meshtasticator radio-physics and policy work split from the original large patch. Please review the smaller draft PRs below in order; each slice has its own focused commit, docs/tests, and validation notes.

The stack keeps default simulator behavior unchanged unless the new CLI flags or packaged preset are used. The main goal is to make DCR/DTP experiments measurable in Meshtasticator without asking reviewers to swallow one giant patch at once.

Split Tracker

Review Notes

  • The rollup is not intended to be merged as one patch.
  • The split PRs are stacked because later slices need the simulator hooks and preset from earlier slices.
  • Each split PR body names the intended review commit so the actual new diff is easy to inspect even while stacked.
  • The packaged Batumi scenario is sanitized: simulator geometry, terrain/clutter grids, and aggregate calibration only; no original node names or source identifiers are included.
  • Remaining rollup-only differences are old duplicate documentation/test reshuffles and are intentionally not part of the review stack.

Validation

The split PRs carry focused validation for their own files. The final cleanup slice was checked with focused tests, ruff, compileall, a static/DCR/DCR+DTP smoke comparison, full unittest, diff whitespace checks, and a private-marker scan.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 29, 2026

CLA assistant check
All committers have signed the CLA.

@Komzpa Komzpa force-pushed the codex/batumi-radio-physics branch 8 times, most recently from a5f20d9 to a29a2b5 Compare April 30, 2026 21:38
@zandi
Copy link
Copy Markdown
Contributor

zandi commented May 1, 2026

I'm not a maintainer of this repo and don't claim or intend to be, but respectfully this is a colossal PR (11k lines added with many new files & features) for a repo with, as far as I've seen, a single maintainer who isn't maintaining this repo as their day job. IMO this would need to at minimum be split into separate digestible PRs with clear intention behind the changes to be accepted, but that's not my call. I'll not go on an anti-AI rant for now.

@GUVWAF
Copy link
Copy Markdown
Member

GUVWAF commented May 2, 2026

I agree with the above; while I think there might be useful additions in the PR, it is currently way too big to be reviewed.
I see that you/your AI now created a list with "mergeable slices", which is good and PR #67 looks reasonable in size and affected changes.

Besides that, I would like to keep the main branch clean by only simulating what current Meshtastic devices do or can be configured to. Dynamic Coding Rate is not yet there (there is this open PR though: meshtastic/firmware#10359), so I would propose to keep those on your fork, at least for now.

@Komzpa
Copy link
Copy Markdown
Contributor Author

Komzpa commented May 2, 2026

Thanks @GUVWAF @zandi. I mainly did this to check my hypotheses on meshtastic/firmware#10359 and dynamic power, so I don't offer to main branch something that won't work in practice. DCR seems a win and dynamic power seems a fail. That part is done for me, but I'll be happy to spend some AI tokens to document and clean it up make it useful for future experimenters. Will fix any comments there.

I hope it's not too annoying with the AI-side - without AI in this case I'll still be dreaming to make dynamic power work, here now I have model that it's not a helpful thing on our real mesh. I do not have intention to make your life harder as maintainer, just sharing results that I happen to have.

@Komzpa Komzpa force-pushed the codex/batumi-radio-physics branch from 4791081 to 73e0189 Compare May 3, 2026 18:57
Komzpa added 5 commits May 3, 2026 23:27
After rebasing the radio-policy stack onto current master, the capture/RF model changes produce a new deterministic ten-node baseline. Keep the regression test strict, but update the expected counters to the current modeled behavior.
@Komzpa Komzpa force-pushed the codex/batumi-radio-physics branch from 73e0189 to ec91e5e Compare May 3, 2026 19:31
@Komzpa Komzpa closed this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants