acknowledge tripple press acousticalla and double blink status LED wh… #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en buzzer is deactivated
Member
|
Hello, thanks for the contribution. I think it would be cleaner if it was just an additional buzzer tune played when buzzer is turned off. No need for all the additional code to blink the LEDs. Also please remove all the commented out code that isn't doing anything :) Buzzer On: Also, PRs must be opened against the |
Author
|
changed accordingly: new PR #1501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this modification acknowledges in the handleButtonTriplePress() the activation and deactivation of the buzzer. Moreover it adds a double blink to the status LED when the buzzer is deactivated.