[pull] master from bitcoin:master - #184
Merged
Merged
Conversation
In p2mr_pqc_construction.json, the three-leaf vectors (p2mr_three_leaf_complex, p2mr_three_leaf_alternative) listed intermediary.leafHashes with entries 0 and 2 swapped relative to the depth-first order of the script tree, while the merkle root, scriptPubKey, address and control blocks all follow depth-first order (as do the same trees in p2mr_construction.json). In p2mr_different_version_leaves, scriptPathControlBlocks[1] started with byte 0xc1 although the leaf it commits to has leafVersion 0xfa; the control byte carries the leaf version in its upper 7 bits with the low bit set, so it must be 0xfb. The vector's leafHashes[1] and merkle root already correspond to the 0xfa leaf.
bip360: fix leafHashes order and a control byte in the pqc test vectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )