Restructure PARCE: foundations, conventions, CI, and an ontology-grounded plan - #4
Merged
Merged
Conversation
Add ARCHITECTURE §5 (Ontology grounding): facet -> ontology registry (EFO/UBERON/MONDO/NCBITaxon/ChEBI/PSI-MS/EDAM), and the rule that 'modality' is two controlled fields -- an EFO assay term plus a coarse molecular_layer enum derived by walking EFO is-a ancestors. Pin OLS4 + text2term/Zooma as resolvers (LLM fallback); IDs resolved at runtime, never hardcoded. Sharpen ROADMAP PR 2 (assay + molecular_layer in the schema) and PR 4 (registry constant + lineage derivation + anchor-set open question); log the decisions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…etadata # Conflicts: # docs/ARCHITECTURE.md # docs/ROADMAP.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Sets the foundation for repointing PARCE from an LLM narrative writer to a deterministic, ontology-grounded multi-source harvester whose only LLM use is structured extraction from messy metadata. No production code behavior changes yet — this PR lands the plan, conventions, tooling, and a CI fix so the refactor PRs (2–8) have a clean, green baseline to branch from.
Contents
Planning & conventions
docs/ARCHITECTURE.md— design source-of-truth: design-vs-outcome principle (why cell type is excluded as context), the modality/structure source gradient (CELLxGENE → GEO → PRIDE), the adapter → normalizer → ontology → graph pipeline, the target canonical schema, and §5 Ontology grounding: facet→ontology registry (EFO/UBERON/MONDO/NCBITaxon/ChEBI/PSI-MS/EDAM) and the rule that "modality" is two controlled fields — an EFOassayterm + a coarsemolecular_layerenum derived by walking EFOis-aancestors.CLAUDE.md— working conventions: where the LLM is allowed to live, layout, dependency direction, quality gates, and the per-session working agreement (incl. the unit-test hermeticity rule).docs/ROADMAP.md— living plan with a▶ Next upmarker, an 8-PR sequence, backlog, and a Session Log that each session updates for the next.Tooling / CI
.github/workflows/ci.yml— uv-based, Python 3.11 + 3.13 matrix:ruff check,ruff format --check,mypy src/parce, unitpytest(integration excluded).pyproject.toml— expanded ruff rules (E,F,I,UP,B,SIM,C4,RUF), mypy + pydantic plugin, mypy added to dev deps;uv.lockrefreshed.Fixes
TestRunOrchestrationhermetic — it constructedSettings()(requiredAZURE_AI_PROJECT_ENDPOINT, no default) and only passed locally via a dev.env; CI (no.env) failed. PatchedSettingsvia an autouse fixture.checkout@v5/setup-uv@v6(Node 20 deprecation).Reviewer notes
parce.tools.*andparce.agent.*(the IO modules slated for rewrite). Documented inpyproject.toml+ roadmap; each future PR removes a module's exemption as it migrates — no new exemptions.main.pystill runs the old narrative pipeline; it is removed in PR 3.Verification
All four gates pass on both Python 3.11 and 3.13 in CI. Unit tests verified hermetic by running with
.envmoved aside (reproduces the runner).