[WC-1784] DG: Column drag and drop enhancements #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

yordan-st wants to merge 19 commits into main from feat/WC-1784_DG-coldrag-enhance

Contributor

yordan-st commented Nov 20, 2025 •

edited

Loading

Pull request type

Description

TODO

Rename Header to ColumnContainer
Create new component ColumnHeader and extract JSX from ColumnContainer
Rewrite getSortIcon to SortIcon
Create folder features/column
Add HeaderDragnDrop.store.ts
Extract hooks from GridHeader to HeaderDragnDrop store
Rewrite useDraggable to ColumnHeader.viewModel.ts with mobx
Rewrite ColumnResizer: use hooks to get ColumnStore and Column

github-actions bot added data-widgets automation labels

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch from 0f9af81 to fb41b35 Compare

November 21, 2025 08:22

iobuhov force-pushed the iobuhov_next branch from 6b44437 to fc9dceb Compare

November 21, 2025 12:30

github-actions bot added the shared label

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch from 5f3b6d2 to 0520f25 Compare

November 21, 2025 14:32

github-actions bot removed the automation label

iobuhov force-pushed the iobuhov_next branch from 736304d to e3a4e71 Compare

November 25, 2025 08:12

yordan-st marked this pull request as ready for review

November 26, 2025 08:21

yordan-st requested a review from a team as a code owner

November 26, 2025 08:21

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch 2 times, most recently from 8e73071 to 7bb9a06 Compare

November 26, 2025 15:46

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/features/column/ColumnHeader.viewModel.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/__tests__/Header.spec.tsx Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx Outdated Show resolved Hide resolved

iobuhov requested changes

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/ColumnHeader.tsx Outdated Show resolved Hide resolved

packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts Outdated Show resolved Hide resolved

packages/pluggableWidgets/datagrid-web/src/model/tokens.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx Outdated Show resolved Hide resolved

iobuhov force-pushed the iobuhov_next branch from e430570 to e3a73dd Compare

November 27, 2025 13:42

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch 2 times, most recently from 75213b1 to bb74b16 Compare

November 28, 2025 10:27

iobuhov reviewed

View reviewed changes

packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/model/hooks/injection-hooks.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/model/tokens.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/model/tokens.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts Outdated Show resolved Hide resolved

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/model/containers/Datagrid.container.ts Outdated Show resolved Hide resolved

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch from 241d3ac to ab01b65 Compare

December 11, 2025 14:20

github-actions bot removed the shared label

leonardomendix previously approved these changes

View reviewed changes

yordan-st dismissed leonardomendix’s stale review via

c7217d9

December 18, 2025 12:37

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch 2 times, most recently from 34f5303 to 15032e0 Compare

December 23, 2025 11:00

leonardomendix previously approved these changes

View reviewed changes

iobuhov and others added 18 commits

January 6, 2026 17:38


          refactor: migrate event controllers from DI to React Context for simp…

f3eba51

…lified architecture


          refactor: migrate event handlers to container

4288b0f


          refactor: extract drag & drop state and logic to mobx

0967c31


          refactor: update components to use new state management

eb5c962


          refactor: remove obsolete tests and snapshots, create for new component

813d7b6


          refactor: rewrite columnreszier to use injection hooks

e280729


          refactor: enhance ColumnResizer test structure and update snapshot

3e6635e


          refactor: fix failing test

acace57


          feat: enhance drag-and-drop functionality with DragHandle component

e715255


          refactor: fix lint errors

c3f116d


          refactor: standardize use of brandi

878d2ea


          refactor: improve naming, consistency and clean up

2e30233


          refactor: ensure consistent naming, prop destructuring, update tests

735370f


          fix: update SelectActionHandler initialization to use null instead of…

2f94f20

… undefined


          fix: restore sort icon state, add dragndropdesign mode and react icon

50d1892


          chore: update unit test snapshot

05a3d06


          fix: restore individual column reorder and reflect in preview, revert…

ecc83c7

… null pass


          feat: enhance drag-and-drop functionality with new drag handle and st…

e083ab3

…yling adjustments

r0b1n dismissed leonardomendix’s stale review via

ee2203d

January 7, 2026 10:11

r0b1n force-pushed the feat/WC-1784_DG-coldrag-enhance branch from 7d73c50 to ee2203d Compare

January 7, 2026 10:11

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch from ee2203d to ea6e22e Compare

January 7, 2026 16:52


          chore: changelog update

68ca3e0

yordan-st force-pushed the feat/WC-1784_DG-coldrag-enhance branch from ea6e22e to 68ca3e0 Compare

January 7, 2026 17:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels