[RUN-3090] Update for s3 sdk changes. #10550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkvanMents
requested changes
Jan 7, 2026
Collaborator
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Hi Emir,
Thanks for the PR. I've moved it under Custom-Settings as it seems to fit better there.
You can see my changes in https://github.com/mendix/docs/pull/10550/files/84ed2b1e9517ec4f54e7f554fc695e77e8d84c5f..cf05d674becae2ebdf6ed47dd196c7123bdd34d4.
I have a couple of questions - can you have a look at them?
Thanks.
content/en/docs/refguide/runtime/custom-settings/s3-encryption-key-update.md
Show resolved
Hide resolved
content/en/docs/refguide/runtime/custom-settings/s3-encryption-key-update.md
Outdated
Show resolved
Hide resolved
…-key-update.md Co-authored-by: Mark van Ments <35492184+MarkvanMents@users.noreply.github.com>
MarkvanMents
approved these changes
Jan 7, 2026
Collaborator
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Looks good.
Can I merge this and #10440 now, or do they need to wait for something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain settings changes and how to perform key update.