fix(coverage): pass --sha explicitly to Codecov uploader#479
Closed
p-targowicz wants to merge 2 commits into
Closed
fix(coverage): pass --sha explicitly to Codecov uploader#479p-targowicz wants to merge 2 commits into
p-targowicz wants to merge 2 commits into
Conversation
p-targowicz
force-pushed
the
fix/QA-1574-codecov-pass-sha
branch
3 times, most recently
from
b7e3f96 to
4aea989
Compare
Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech> Ticket: QA-1574 Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech>
p-targowicz
force-pushed
the
fix/QA-1574-codecov-pass-sha
branch
from
a500810 to
e43402a
Compare
Add SHA256SUM verification for the codecov binary download across all three coverage templates to prevent running a tampered binary. Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech> Ticket: QA-1574 Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #478.
After unsetting
GITLAB_CIto prevent service auto-detection, the Codecov uploader can no longer infer the commit SHA from GitLab env vars, causing uploads to fail withUnable to detect SHA and slug.Fix: pass
--sha ${CI_COMMIT_SHA}explicitly so the uploader has everything it needs without relying on GitLab CI auto-detection.Ticket: QA-1574