Men 9436 by mineralsfree · Pull Request #1831 · mendersoftware/mender-server

mineralsfree · 2026-05-13T16:03:56Z

No description provided.

codecov · 2026-05-15T14:05:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

mzedel

looks pretty close 👍, just some small alignment questions + the tests (the e2e tests would be happy to see the friendlier upload used 😄

mzedel · 2026-05-15T14:56:30Z

 export const DefaultUpgradeNotification = props => (
  <div {...props}>
-    This feature is not available on your plan. <Link to="/subscription">Upgrade</Link> to enable it
+    <span>


why this? (+ the commit this is in doesn't align with the change)

There was an issue with new Links that would cause it to render line by line; solved it differently

mzedel · 2026-05-15T14:57:49Z

  rbac: { id: 'rbac', path: 'overview/role.based.access.control' },
-  webhookSecret: { id: 'webhookSecret', path: 'server-integration/webhooks#signature-header' }
+  webhookSecret: { id: 'webhookSecret', path: 'server-integration/webhooks#signature-header' },
+  orchestratorManifest: { id: 'orchestratorManifest', path: 'orchestrate-updates/manifest' }


🙏 slightly further up, to keep it sorted

mzedel · 2026-05-15T14:59:46Z

+    maxWidth: '400px'
+  }
+}));
+const isYaml = (filename: string) => filename.endsWith('.yaml');


even though we reference .yaml I would expect both the upload and the processing to handle .yml too...

mzedel · 2026-05-15T15:29:17Z

+          <Typography className="margin-top-medium margin-bottom-x-small" variant="subtitle1">
+            Notes
+          </Typography>
+          <TextInput id="description" hint="Add notes here" InputLabelProps={{ shrink: true }} />
+          <Typography className="margin-top-medium margin-bottom-x-small" variant="subtitle1">
+            Tags
+          </Typography>
+          <ChipSelect className={classes.input} options={existingTags} name="tags" placeholder="Add Tags" forcePopupIcon={existingTags.length !== 0} />


for such sections the ContentSection component was meant to bring consistency

Suggested change

<Typography className="margin-top-medium margin-bottom-x-small" variant="subtitle1">

Notes

</Typography>

<TextInput id="description" hint="Add notes here" InputLabelProps={{ shrink: true }} />

<Typography className="margin-top-medium margin-bottom-x-small" variant="subtitle1">

Tags

</Typography>

<ChipSelect className={classes.input} options={existingTags} name="tags" placeholder="Add Tags" forcePopupIcon={existingTags.length !== 0} />

<ContentSection title="Notes">

<TextInput id="description" hint="Add notes here" InputLabelProps={{ shrink: true }} />

</ContentSection>

<ContentSection title="Tags">

<ChipSelect className={classes.input} options={existingTags} name="tags" placeholder="Add Tags" forcePopupIcon={existingTags.length !== 0} />

</ContentSection>

mzedel · 2026-05-15T15:31:58Z

+          <Typography className="margin-top-medium margin-bottom-x-small" variant="subtitle1">
+            Notes
+          </Typography>
+          <TextInput id="description" hint="Add notes here" InputLabelProps={{ shrink: true }} />


This is supposed to be multiline ☝️
In the ManifestDetails this is a EditableLongText - if both would rely on this we could adjust the EditableLongText to match the design + other areas (IOW unify release & artifact details) in one go 😉

I agree that multiline fits better for notes (description) here, but I decided to keep it as in the design for now (TextInput). The EditableLongText API is not compatible with TextInput now and it does not render as multiline anyway.

https://www.figma.com/design/IbQQwOxnbYX0s3eb4MAUu8/Orchestrator--Creating-Manifests-in-the-UI?node-id=6134-51630&t=9Qhoyrh0xBpdE1WF-4 design says multiline, the other components use EditableLongText for multiline => if we refactor that one component we have it correct in all 3 places, with your change here that's not possible and we get more misalignment.

Created https://northerntech.atlassian.net/browse/MEN-9730 so we can hopefully align this in the coming sprint to close the "enablement epic"

Thank you! It is not easy to notice those small footnote comments in a Figma file. 😬 Ok, I'll try to use EditableLongText without breaking anything

mzedel · 2026-05-15T15:44:22Z

+  useEffect(() => {
+    dispatch(getExistingManifestTags());
+  }, [dispatch]);


could this also live in the ManifestsList as both will have to have the data anyway, but the ManifestDrawer is a child of the list/ to limit the duplicate request in case of a link to the manifest?

mzedel · 2026-05-15T15:50:30Z

+  };
+
+  return (
+    <BaseDrawer open={open} size="sm" onClose={onClose} slotProps={{ header: { title: 'Upload a Manifest' } }}>


is "sm" enough for this?

it works on my screen 😄 (switched to md)

mzedel · 2026-05-15T15:50:57Z

+              onDrop={onDrop}
+              accept={{
+                'application/octet-stream': ['.mender'],
+                'application/x-yaml': ['.yaml']


Suggested change

'application/x-yaml': ['.yaml']

'application/yaml': ['.yaml', 'yml']

to align with https://www.iana.org/assignments/media-types/media-types.xhtml

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

…performance Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

+ moved tag fetching to manifest list Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

+ added the reset on drawer close Ticket: MEN-8205 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

mzedel

the selector in the tests can surely be changed later on 👌

mineralsfree requested a review from a team as a code owner May 13, 2026 16:03

mineralsfree added the WIP label May 13, 2026

mineralsfree force-pushed the men-9436 branch 3 times, most recently from 540aa52 to 6d74e0c Compare May 15, 2026 13:48

mzedel reviewed May 15, 2026

View reviewed changes

mineralsfree force-pushed the men-9436 branch 2 times, most recently from 962f43e to dc64606 Compare May 18, 2026 14:12

mineralsfree added 10 commits May 19, 2026 12:57

feat(gui): added Manifest creation Drawer

0e0095a

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): adjusted common components to support more props

b186785

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): export reused table and file filter

521aced

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): include manifest creation drawer on the software page

a40abf2

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): updated and added dependencies

ea1aecf

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): updated snapshots

3055ab9

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): let vite resolve store pkg post-MUI migration for better …

558717f

…performance Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): fixed upgrade notice layout

e5e803a

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

chore(gui): added .yaml upload request

b02012e

+ moved tag fetching to manifest list Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

test(gui): added unit & e2e tests covering manifest upload

a2ccb08

Ticket: MEN-9436 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

mineralsfree force-pushed the men-9436 branch from dc64606 to 43814ca Compare May 19, 2026 11:24

chore(gui): swapped text input with editableLongText

935ab41

+ added the reset on drawer close Ticket: MEN-8205 Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>

mineralsfree force-pushed the men-9436 branch from 43814ca to 935ab41 Compare May 19, 2026 11:39

mzedel approved these changes May 19, 2026

View reviewed changes

Comment thread frontend/src/js/components/releases/manifests/ManifestDrawer.test.tsx

mineralsfree removed the WIP label May 19, 2026

mineralsfree merged commit 747d723 into mendersoftware:main May 19, 2026
2 checks passed

	'application/x-yaml': ['.yaml']
	'application/yaml': ['.yaml', 'yml']

Conversation

mineralsfree commented May 13, 2026

Uh oh!

codecov Bot commented May 15, 2026

Codecov Report

Uh oh!

mzedel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mzedel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants