Skip to content

Use x/term instead of howeyc/gopass#344

Open
jas4711 wants to merge 5 commits into
mendersoftware:masterfrom
jas4711:avoid-howeyc-gopass
Open

Use x/term instead of howeyc/gopass#344
jas4711 wants to merge 5 commits into
mendersoftware:masterfrom
jas4711:avoid-howeyc-gopass

Conversation

@jas4711
Copy link
Copy Markdown

@jas4711 jas4711 commented Mar 28, 2026

Hi! We will use this patch in Debian to avoid a dependency on the deprecated and obsolete https://github.com/howeyc/gopass library, using standard golang.org/x/term instead.

Thanks,
Simon

@jas4711 jas4711 requested a review from a team as a code owner March 28, 2026 09:26
@alfrunes
Copy link
Copy Markdown
Contributor

Hello @jas4711 👋
Thank you for the contribution!
In order to get your PR approved, could you please reword your commit message format to a semantic commit format and add the signoff trailer?

git commit --amend --signoff -m 'chore: replaced github.com/howeyc/gopass with golang.org/x/term'

@alfrunes alfrunes force-pushed the avoid-howeyc-gopass branch from 3b265eb to 575607b Compare April 29, 2026 08:44
@alfrunes alfrunes requested a review from frodeha April 29, 2026 08:44
@alfrunes alfrunes self-assigned this Apr 29, 2026
@alfrunes alfrunes removed the request for review from a team April 29, 2026 08:45
Copy link
Copy Markdown

@frodeha frodeha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

alfrunes and others added 3 commits April 29, 2026 13:19
Co-Authored-By: Simon Josefsson <simon@josefsson.org>
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
@alfrunes alfrunes force-pushed the avoid-howeyc-gopass branch from 575607b to 2e7a9d6 Compare April 29, 2026 11:21
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants