Skip to content

chore(tests): remove dead code and hardcoded sleeps#2900

Open
p-targowicz wants to merge 1 commit into
masterfrom
chore/QA-1616-remove-dead-code
Open

chore(tests): remove dead code and hardcoded sleeps#2900
p-targowicz wants to merge 1 commit into
masterfrom
chore/QA-1616-remove-dead-code

Conversation

@p-targowicz
Copy link
Copy Markdown
Contributor

@p-targowicz p-targowicz commented May 19, 2026 •
edited
Loading

  • Remove extra/travis-testing/ (Travis CI legacy, repo uses GitLab CI)
  • Remove extra/stripe-testing/ and testutils/integration/stripe.py (Stripe testing infra, not referenced in any CI config or test imports) + drop stripe from python requirements
  • Replace time.sleep() calls in test_mender_connect.py and test_filetransfer.py that wait for mender-connect reconnection with wait_for_connect(), which polls the management API via redo.retrier

QA-1616, QA-1638

@p-targowicz p-targowicz requested a review from a team as a code owner May 19, 2026 06:59
@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 19, 2026

@p-targowicz, start a full integration test pipeline with:

  • mentioning me and start integration pipeline
my commands and options

You can prevent me from automatically starting CI pipelines:

  • if your pull request title starts with "[NoCI] ..."

You can trigger a client pipeline on multiple prs with:

  • mentioning me and start client pipeline --pr mender/127 --pr mender-connect/255

You can trigger a client pipeline for a specific Mender Client release with:

  • mentioning me and start client pipeline --release 6.0.x (can be given multiple times)
  • by default, a pipeline is triggered for each supported release the component is a part of

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can print PR statistics for a repository with:

  • mentioning me and print fast pr stats (Team stats only)
  • mentioning me and print full pr stats (Detailed report)
  • options: --repo <repo>, --team <name>, --all-repos, --exclude-drafts, --exclude-user <user>
  • mentioning me and print full pr stats --repo mender --all-repos --exclude-drafts

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@p-targowicz
Copy link
Copy Markdown
Contributor Author

p-targowicz commented May 19, 2026

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 19, 2026

Hello 😺 I created a pipeline for you here: Pipeline-2536252553

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2900/head
RUN_TESTS_FULL_INTEGRATION true

@p-targowicz p-targowicz force-pushed the chore/QA-1616-remove-dead-code branch from 5301a8b to f4fc250 Compare May 19, 2026 07:40
@p-targowicz
Copy link
Copy Markdown
Contributor Author

p-targowicz commented May 19, 2026

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 19, 2026

Hello 😺 I created a pipeline for you here: Pipeline-2536354903

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2900/head
RUN_TESTS_FULL_INTEGRATION true

@p-targowicz p-targowicz force-pushed the chore/QA-1616-remove-dead-code branch 5 times, most recently from 94ab95e to c27ba83 Compare May 19, 2026 12:05
@p-targowicz
Copy link
Copy Markdown
Contributor Author

p-targowicz commented May 19, 2026

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 19, 2026

Hello 😺 I created a pipeline for you here: Pipeline-2537195101

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2900/head
RUN_TESTS_FULL_INTEGRATION true

@p-targowicz
Copy link
Copy Markdown
Contributor Author

p-targowicz commented May 19, 2026

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 19, 2026

Hello 😺 I created a pipeline for you here: Pipeline-2537196703

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2900/head
RUN_TESTS_FULL_INTEGRATION true

@p-targowicz p-targowicz force-pushed the chore/QA-1616-remove-dead-code branch from c27ba83 to c6a426a Compare May 19, 2026 20:09
@p-targowicz
Copy link
Copy Markdown
Contributor Author

p-targowicz commented May 19, 2026

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 19, 2026

Hello 😺 I created a pipeline for you here: Pipeline-2538446691

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2900/head
RUN_TESTS_FULL_INTEGRATION true

@p-targowicz p-targowicz force-pushed the chore/QA-1616-remove-dead-code branch from c6a426a to e231fb0 Compare May 19, 2026 20:24
@p-targowicz
Copy link
Copy Markdown
Contributor Author

p-targowicz commented May 20, 2026

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 20, 2026

Hello 😺 I created a pipeline for you here: Pipeline-2538886406

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2900/head
RUN_TESTS_FULL_INTEGRATION true

@p-targowicz p-targowicz force-pushed the chore/QA-1616-remove-dead-code branch from e231fb0 to 8bfe6db Compare May 20, 2026 07:57
@p-targowicz
chore(tests): remove dead code, hardcoded sleeps, and list(set()) ant…
5048872 
…i-pattern

Remove extra/travis-testing (Travis CI legacy), extra/stripe-testing,
testutils/integration/stripe.py (unused, no imports), and stripe from
python requirements.

Replace time.sleep() calls waiting for mender-connect reconnection
with wait_for_connect(), which polls the management API via
redo.retrier. Also remove the redundant 4s sleep before an existing
wait_for_connect() call in set_limits().

Replace list(set([device["id"] for device in ...])) with a direct
get_devices_status() call. Device IDs are already unique so the
set() was unnecessary, and the comprehension discarded the status
dicts while silently changing devices[0] from a dict to a raw ID
string.

Ticket: QA-1616
Ticket: QA-1638
Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech>
@p-targowicz p-targowicz force-pushed the chore/QA-1616-remove-dead-code branch from 8bfe6db to 5048872 Compare May 20, 2026 09:17
@p-targowicz
Copy link
Copy Markdown
Contributor Author

p-targowicz commented May 20, 2026

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link
Copy Markdown
Contributor

mender-test-bot commented May 20, 2026

Hello 😺 I created a pipeline for you here: Pipeline-2539937154

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2900/head
RUN_TESTS_FULL_INTEGRATION true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@p-targowicz @mender-test-bot