fix(pullreq_pipeline): remove hardcoded git identity from amend command#449
Merged
Conversation
|
There was an error syncing branches, see logs for details. |
The user.email and user.name -c flags override the git identity for the amend commit, which is unnecessary and ties the runner to a specific bot account. Removing them lets git use the configured identity from the environment. Ticket: QA-1505 Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech>
p-targowicz
force-pushed
the
QA-1505-remove-git-identity-flags
branch
from
0bf13dd to
bd64642
Compare
|
There was an error syncing branches, see logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user.email and user.name -c flags override the git identity for the amend commit - it leads to sync issue #448 (comment)
Ticket: QA-1505