Skip to content

Handle specific exceptions in HTTPClientInterceptor with detailed res… #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rrayst merged 4 commits into from
May 26, 2026
+39 −11
Merged

Handle specific exceptions in HTTPClientInterceptor with detailed res… #2945

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9320431
Handle specific exceptions in HTTPClientInterceptor with detailed res…
predic8 May 14, 2026
6b59373
Merge branch 'master' into network-error-messages
predic8 May 14, 2026
949d867
Merge branch 'master' into network-error-messages
predic8 May 22, 2026
c77aea7
Merge branch 'master' into network-error-messages
rrayst May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 39 additions & 11 deletions core/src/main/java/com/predic8/membrane/core/interceptor/HTTPClientInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,26 @@
limitations under the License. */
package com.predic8.membrane.core.interceptor;

import com.predic8.membrane.annot.*;
import com.predic8.membrane.core.exchange.*;
import com.predic8.membrane.core.proxies.*;
import com.predic8.membrane.core.transport.http.*;
import com.predic8.membrane.core.transport.http.client.*;
import com.predic8.membrane.core.util.*;
import org.slf4j.*;
import com.predic8.membrane.annot.MCAttribute;
import com.predic8.membrane.annot.MCChildElement;
import com.predic8.membrane.annot.MCElement;
import com.predic8.membrane.core.exchange.Exchange;
import com.predic8.membrane.core.proxies.AbstractServiceProxy;
import com.predic8.membrane.core.transport.http.EOFWhileReadingLineException;
import com.predic8.membrane.core.transport.http.HttpClient;
import com.predic8.membrane.core.transport.http.ProtocolUpgradeDeniedException;
import com.predic8.membrane.core.transport.http.UnableToTunnelException;
import com.predic8.membrane.core.transport.http.client.HttpClientConfiguration;
import com.predic8.membrane.core.util.URLUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.net.*;

import static com.predic8.membrane.core.exceptions.ProblemDetails.*;
import static com.predic8.membrane.core.interceptor.Interceptor.Flow.Set.*;
import static com.predic8.membrane.core.interceptor.Outcome.*;
import static com.predic8.membrane.core.interceptor.Interceptor.Flow.Set.REQUEST_FLOW;
import static com.predic8.membrane.core.interceptor.Outcome.ABORT;
import static com.predic8.membrane.core.interceptor.Outcome.RETURN;

/**
* @description The <i>httpClient</i> sends the request of an exchange to a Web
Expand Down Expand Up @@ -83,19 +90,40 @@ public Outcome handleRequest(Exchange exc) {
httpClient.call(exc);
return RETURN;
} catch (ConnectException e) {
String msg = "Target %s is not reachable.".formatted(getDestination(exc));
var msg = "Target %s is not reachable.".formatted(getDestination(exc));
log.warn("{} {}", msg, PROXIES_HINT);
gateway(router.getConfiguration().isProduction(), getDisplayName())
.title("Bad Gateway")
.addSubSee("connect")
.status(502)
.detail(msg)
.buildAndSetResponse(exc);
return ABORT;
} catch (SocketException e) {
internal(router.getConfiguration().isProduction(), getDisplayName())
.title("Bad Gateway")
.status(502)
.addSubSee("socket-exception")
.detail("Error communicating with target %s. Reason: %s".formatted(exc.getDestinations(), e.getMessage()))
.stacktrace(false)
.buildAndSetResponse(exc);
return ABORT;
} catch (EOFWhileReadingLineException e) {
internal(router.getConfiguration().isProduction(), getDisplayName())
.title("Bad Gateway")
.status(502)
.detail("Backend closed the connection before the response was complete.")
.addSubSee("socket-closed")
.stacktrace(false)
.buildAndSetResponse(exc);
return ABORT;
} catch (SocketTimeoutException e) {
// Details are logged further down in the HTTPClient
log.info("Target {} is not reachable.",exc.getDestinations());
internal(router.getConfiguration().isProduction(), getDisplayName())
.title("Gateway Timeout")
.status(504)
.addSubSee("socket-timeout")
.detail("Target %s is not reachable.".formatted(exc.getDestinations()))
.buildAndSetResponse(exc);
Comment thread
predic8 marked this conversation as resolved.
return ABORT;
} catch (UnknownHostException e) {
Expand Down
Loading