Update vscode to latest main version.#82
Merged
Merged
Conversation
In FileSystemWatcher, if a "created" event fired for `tmpfs:///project/` It would fire the event for files sharing the same prefix but different scheme. In our case: `memfs:///project/package.json` This caused an assertion in typescript-language-features breaking intellisense. I also added a new test but it doesn't test this particular fix.
* Update the web build to have a vscode-web and vscode-web-min step * Don't run git config commands in submodule * Fix plugin path to work as submodule of mnode * Add some extra context around postinstall changes * Fix platform path
- Don't throw when key is not a JSON - Don't throw when key is not found, return undefined instead. - Simplify a bit
* Disable terminal functionality I removed most of the terminal-related contributions (terminal.contribution.ts), which includes: commands, the terminal tab, menu items, keybindings, and so on. Many terminal-related services are used by other services (e.g. the task service depends on the terminal service), so removing TerminalService would cause a cascade of "missing singleton" errors. Thankfully vscode uses DI everywhere, so I replaced the TerminalService with our own empty shell of a service. Same for a few related services. The empty shells are there to satisfy the dependency injection system. Note that there's still quite a bit of terminal-related code left that I think will end up in our build. We might be able to use a webpack plugin to for example, replace xterm.js with a dummy module. * Undo extension webpack change
…13) * Add getAuthToken * fix log error and remove token cache
* Remove unused features * Comment out unused code
* add membrane user settings * fix commandService usage * add save/update membrane gaze data * add try catch * new settings req and fix update command * move get/update data to runInTransaction * fix membrane module * change the proxy to use async code * fix the indexeddb proxy reqs * use getAllKeys to restore settings
* Fix import cycle causing the build to fail * Add membrane.ts
* Exclude unused extensions from build * Formatting
- Add membrane.reportModalState command handler
- Remove double-click listener for creating new untitled files - Remove related imports (DEFAULT_EDITOR_ASSOCIATION, EditorServiceImpl) - Clean up unused editor service dependencies
- Show only User settings tab - Remove workspace and folder settings from preferences UI
- Remove command palette from editor context menu - Disable ShowAllCommandsAction registration - Clean up related imports and menu registrations
- Remove 'memento/webviewView.membrane.main' from membrane keys
* hide lock group and editor actions positioning settings from menus * show editor actions in tab bar * add membrane dialog and notification handlers to intercept dialogs and notifications to display them with our own UI in gaze
* Replace addEventListener with MessageChannel. * Use handoff to pass port. * Use messageChannel for handle dialogs.
* Replace addEventListener with MessageChannel. * Use handoff to pass port. * Use messageChannel for handle dialogs. * Simplify message passing between gaze, extension and membrane dialog manager --------- Co-authored-by: aranajhonny <jhonnyjosearana@gmail.com>
Signed-off-by: Jhonny Arana <jhonnyjosearana@gmail.com>
Signed-off-by: Jhonny Arana <jhonnyjosearana@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE
This was accidentally merged to main but the actual commits live in the
membranebranch