Refactor Index/Indexes separation and modernize Search API#914
Draft
norkunas wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
549fe91 to
5fd0c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #840
Fixes #760
What does this PR do?
This PR performs a major architectural refactor of the
Indexhandling and modernizes the Search API to leverage modern PHP features and stricter static analysis.1. Architectural Separation of
IndexesandIndexIndexes.phpfor/indexes) from instance-specific operations (Index.phpfor/indexes/{uid}).HandlesDocuments,HandlesSettings, andHandlesTaskstraits to theIndexclass. This ensures instance methods always have a validuidcontext.fill()andnewInstance()pattern. Hydration is now handled via an explicitIndex::fromArray()factory.2. Implementation of Metadata Lazy Loading
primaryKey,createdAt, andupdatedAt.getPrimaryKey(),getCreatedAt(), orgetUpdatedAt(). The use ofisset()sentinels ensures that anullprimary key doesn't trigger redundant API calls once the instance is loaded.3. Modernized Search API
SearchQueryObject: Introduced a dedicatedSearchQuerycontract for single-index searches, while renaming the multi-search oriented class toMultiSearchQuery.Index::search()andIndex::rawSearch()to use native PHP 8.0 union types (string|SearchQuery|null). This supports both the traditional string-based queries and the new typed object API, ensuring full backward compatibility.media(multimodal) andretrieveVectorsparameters.4. Engineering Standards & Tooling
non-empty-stringPHPStan pseudo-type for identifiers and timestamps.Httpcontract instead of theIndexclass) and verified all changes against a live Meilisearch instance.PR checklist
Please check if your PR fulfills the following requirements:
AI Disclosure:
This PR was implemented with the assistance of Gemini 2.0 Flash (Experimental) via the Gemini CLI agent. The AI was used to automate the mass refactoring of the test suite (updating imports and typehints across 30+ files), assist in the design of the lazy-loading sentinel pattern, and ensure strict PHPStan array shape compliance across the new
SearchQueryandIndexcontracts. All AI-generated changes were empirically verified via PHPUnit and static analysis.